picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

stat-util: don't try to open path on path_is_temporary_fs() 

I mean, the old code at least used O_PATH, but still, we shouldn't
allocate/close an fd if we don't have to.
This commit is contained in:
Lennart Poettering 2021-01-06 18:05:56 +01:00 committed by Luca Boccassi
parent 4832454cb6
commit 15308e5083
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/basic/stat-util.c
View File

@ -226,13 +226,12 @@ int fd_is_network_fs(int fd) {
}
int path_is_temporary_fs(const char *path) {
_cleanup_close_ int fd = -1;
struct statfs s;
fd = open(path, O_RDONLY|O_CLOEXEC|O_NOCTTY|O_PATH);
if (fd < 0)
if (statfs(path, &s) < 0)
return -errno;
return fd_is_temporary_fs(fd);
return is_temporary_fs(&s);
}
int stat_verify_regular(const struct stat *st) {