shared/install: log syntax error for invalid DefaultInstance=

Ideally, we would want to report this over back over dbus. But that is pretty hard,
because the unitfile parsing logic doesn't provide any feedback.
systemd-analyze verify also doesn't notice the issue, because it doesn't look
at the [Install] section at all. Let's print a message in the logs at least.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2019-12-13 19:25:50 +01:00
parent d7ceaf7261
commit e51712963b
2 changed files with 3 additions and 1 deletions

1
TODO
View File

@ -1039,6 +1039,7 @@ Features:
- introduce mix of BindTo and Requisite
- add a concept of RemainAfterExit= to scope units
- Allow multiple ExecStart= for all Type= settings, so that we can cover rescue.service nicely
- add verification of [Install] section to systemd-analyze verify
* udev-link-config:
- Make sure ID_PATH is always exported and complete for

View File

@ -1197,7 +1197,8 @@ static int config_parse_default_instance(
}
if (!unit_instance_is_valid(printed))
return -EINVAL;
return log_syntax(unit, LOG_WARNING, filename, line, SYNTHETIC_ERRNO(EINVAL),
"Invalid DefaultInstance= value \"%s\".", printed);
return free_and_replace(i->default_instance, printed);
}