Commit Graph

3528 Commits

Author SHA1 Message Date
Sami Kerola 23757887f7 licence: remove references to old FSF address
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57206
2012-12-17 11:41:31 +01:00
Zbigniew Jędrzejewski-Szmek 80701564cd journal: move _packed_ attribute to the end
GCC manual states that "For an enum, struct or union type, you may
specify attributes either between the enum, struct or union tag and
the name of the type, or just past the closing curly brace of the
definition. The former syntax is preferred." This means that the
attribute should not be located before 'struct'. Putting it between
'struct' and the name seems cluttered. Putting it at the end seems
most readable.

This avoids clang warnings.
2012-12-17 11:41:31 +01:00
Richard Yao e683136da1 Fix "attribute 'packed' is ignored" warnings when using Clang
Clang 3.1 warned that "attribute 'packed' is ignored". This stems from
placing "__attribute__ ((packed))" at the start of structure
declarations when common practice is to place it at the end.

Signed-off-by: Richard Yao <ryao@gentoo.org>
2012-12-17 10:43:58 +01:00
Michael Terry e688930750 libudev: validate 'udev' argument to udev_enumerate_new()
https://bugs.freedesktop.org/show_bug.cgi?id=58289
2012-12-14 15:36:47 +01:00
Michal Schmidt 6b2b6f30e3 localectl: fix dbus call arguments in set_x11_keymap
Fixes an assertion failure in the dbus lib.
https://bugzilla.redhat.com/show_bug.cgi?id=882212
2012-12-12 22:29:06 +01:00
Eric Benoit f4443fa597 libudev: hwdb: add missing endianess conversion
https://bugs.freedesktop.org/show_bug.cgi?id=58067
2012-12-11 15:34:56 +01:00
Kay Sievers decd634e80 udev: net_id: update comments 2012-12-09 14:49:28 +01:00
Michal Schmidt 735e071271 shutdown, umount: use verbs consistently
Mounts are "unmounted".
Swaps are "deactivated", not "turned off" nor "disabled".
Loop and DM devices are "detached", not "deleted".

Especially the deleting sounded a bit scary.
2012-12-07 18:55:19 +01:00
Michal Schmidt bce93b7ac7 shutdown, umount: logging improvements
In bugreports about hangs during the late shutdown we are often missing
important information - what were we trying to unmount/detach when it hung.

Instead of printing what we successfully unmounted, print what we are
going to unmount/detach. And add messages to mark the completion of
categories (mount/swap/loop/DM).
2012-12-07 17:44:50 +01:00
Michal Schmidt c678406681 umount: fix check for DM changed
delete_dm() returns 0 on success. The check for "r > 0" was likely
a copy&paste error from the loopback code where "r > 0" makes sense.
2012-12-07 17:34:21 +01:00
Michal Schmidt 2569a5ce16 shutdown: downgrade a warning
All messages of the kind "not all done, %d left" are log_info, except
the one for DM devices. Make it info too.
2012-12-07 17:28:30 +01:00
Kay Sievers 971e7fb625 udev: net_id - fix OUI handling 2012-12-06 21:37:10 +01:00
Kay Sievers 0d6ce9236f udev: net_id - fix typos 2012-12-06 21:27:42 +01:00
Kay Sievers ad37f393fa udev: net_id - update examples 2012-12-06 21:25:39 +01:00
Kay Sievers f610d6de38 udev: net_id - update examples 2012-12-06 21:09:30 +01:00
Kay Sievers 0260944060 udev: net_id - provide path names for USB devices 2012-12-06 20:44:28 +01:00
Michal Schmidt 4b9d3dc974 systemctl: verbose message on missing [Install]
People still don't understand what the message implies.
We have to be more verbose (or more intelligent and detect some of the
cases automatically, but that's not so easy).

https://bugzilla.redhat.com/show_bug.cgi?id=884438
2012-12-06 16:25:39 +01:00
Zbigniew Jędrzejewski-Szmek 20ad4cfd8e core: add catalog entry and MESSAGE_ID for overmounting 2012-12-05 12:25:50 +01:00
Zbigniew Jędrzejewski-Szmek c007bb1b4d modules-load: fix memory leak when bailing out
Suggested-by: Mauro Dreissig <mukadr@gmail.com>
2012-12-04 14:03:40 +01:00
Tom Gundersen 5fe25affc0 hwdb: add IAB to the OUI database
The individual address block is a poor man's organizationally unique
identifier.

Perhaps we should change the udev key from ID_OUI_FROM_DATABASE to
something like ID_IEEE_VENDOR_FROM_DATABASE?

Suggested-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>
2012-12-04 02:11:37 +01:00
Umut Tezduyar d9847b3246 systemctl: fix typos in help text 2012-12-03 16:05:01 +01:00
Kay Sievers 137661d875 udev: net_id - clarify comments 2012-12-03 15:47:18 +01:00
Shawn Landden b779821b8f timedated: do not incorrectly close non-opened dbus connection
Fix the fallowing error when no system dbus available:

Failed to get system D-Bus connection: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory
process 14920: arguments to dbus_connection_close() were incorrect, assertion "connection != NULL" failed in file ../../dbus/dbus-connection.c line 2889.
This is normally a bug in some application using the D-Bus library.
process 14920: arguments to dbus_connection_unref() were incorrect, assertion "connection != NULL" failed in file ../../dbus/dbus-connection.c line 2776.
This is normally a bug in some application using the D-Bus library.
2012-12-03 01:56:42 +01:00
David Herrmann a705d08519 getty-generator: fix handling systems without a console
If the system does not have any active console, we should not try to
create an empty symlink. Instead, create no symlink at all.

Otherwise, on systems with CONFIG_VT=n and no serial console, we will
create a symlink with an empty template parameter.
2012-12-02 18:18:27 +01:00
Kay Sievers 472780d8b1 udev: hwdb - fix OUI lookup 2012-12-02 02:00:57 +01:00
Zbigniew Jędrzejewski-Szmek 6f862a69ec cgls: automatic cleanup 2012-12-01 16:38:32 +01:00
Kay Sievers de892aea1c udev: net_id - suppress function number for single-function devices 2012-11-30 19:27:42 +01:00
Martin Pitt a5dea3d43b keymap: Add Samsung 700T
https://bugzilla.redhat.com/show_bug.cgi?id=879691
2012-11-28 21:33:26 +01:00
Alessandro Crismani 68c77c2f61 keymap: Update the list of Samsung Series 9 models
Currently, keymaps are provided only for the NP90X3A laptop. Samsung
introduced updated models, codenamed 900X3B, 900X3C, 900X4B, 900X4C,
which are currently not matched by udev rules. This patch includes the
newer modules in udev rules and move the samsung-n90x3a file defining
keys to a more generic samsung-series-9 file.

The patch was tested on a 900X4C laptop, and other people reported
that the rules also work for 900X3B and 900X3C ones.
2012-11-28 21:27:03 +01:00
Hermann Gausterer 5a6f9d2330 shutdown: fix typo 2012-11-28 21:22:39 +01:00
Tom Gundersen 140883405e shutdown: don't consider umounting of / and /usr failed
In the words of Homer: If you don't try, you can't fail.

This is a revert of 9279749b84.

It used to be necessary to consider the umounting failed to make sure /
and /usr were remounted read-only, but that is no longer necessary as
everything is now remounted read-only anyway.

Moreover, this avoids a warning at shutdown saying a filesystem was not
unmounted. As the umounting of / is never attempted there was no
corresponding warning message saying which fs that failed. This caused some
spurious bug-reports from concerned users.

Cc: Michael Biebl <biebl@debian.org>
2012-11-28 18:26:35 +01:00
Tom Gundersen 02eaa78835 shutdown: don't pivot to /run/initramfs if already there
This allows systemd-shutdown to be installed as /run/initramfs/shutdown
and take care of the proper teardown of the rootfs.
2012-11-28 18:26:35 +01:00
Tom Gundersen 67ab5f761f fstab-generator: make error more helpful in case of duplicates in fstab
Traditional sysvinit systems would not complain about duplicates in
fstab. Rather it (through monut -a) would mount one fs on top of another,
in effect the last entry taking precedent.

In systemd, the first entry takes precedent, all subsequent ones are
ignored and an error is printed.

The change of behavior and the source of this error message was causing
some confusion, so give a hint what migt be wrong.
2012-11-27 01:57:57 +01:00
Tom Gundersen 1d634e21b4 fstab-generator: drop mount_is_bind
Do the check in-line instead, as the function is now a bit pointless.
2012-11-27 00:56:09 +01:00
Tom Gundersen a83cbaccd0 fstab-generator: remove redundancy in mount_is_bind 2012-11-27 00:41:43 +01:00
Kay Sievers 5b8180d3f6 udev: net_id - merge properties into the correct device 2012-11-26 15:03:06 +01:00
Kay Sievers 0035597a30 udev: net_id - export PCI hotplug slot names 2012-11-26 14:07:16 +01:00
Zbigniew Jędrzejewski-Szmek 29abad107f journal: fix warning about pointer arithmetic
../src/journal/journal-send.c: In function 'sd_journal_sendv':
../src/journal/journal-send.c:250:73: warning: pointer of type 'void *' used in arithmetic [-Wpointer-arith]
2012-11-25 21:43:44 +01:00
Lennart Poettering 8a3a1704c7 manager: fix build on 32bit systems 2012-11-25 19:46:16 +01:00
Zbigniew Jędrzejewski-Szmek 4a1909bb66 journal-gatewayd: minor cleanup 2012-11-25 18:04:03 +01:00
Lennart Poettering 8742514c1a timer: recalculate next elapse for calendar timer units when the system clock is changed 2012-11-25 00:33:59 +01:00
Kay Sievers f0d7b0fcff shared: FORMAT_TIMESTAMP_MAX -- include space for unicode weekdays
$ LANG=el_GR.UTF-8 ./timedatectl
      Local time: Σαβ 2012-11-24 14:53:05 CET
  Universal time: Σαβ 2012-11-24 13:53:05 UTC
        RTC time: Σαβ 2012-11-24 13:53:04
        Timezone: Europe/Berlin (CET, +0100)
     NTP enabled: yes
NTP synchronized: yes
 RTC in local TZ: no
      DST active: no
 Last DST change: DST ended at
                  Κυρ 2012-10-28 02:59:59 CEST
                  Κυρ 2012-10-28 02:00:00 CET
 Next DST change: DST begins (the clock jumps one hour forward) at
                  Κυρ 2013-03-31 01:59:59 CET
                  Κυρ 2013-03-31 03:00:00 CEST

https://bugs.freedesktop.org/show_bug.cgi?id=57470
2012-11-24 14:55:35 +01:00
Lennart Poettering 0979f2855c build-sys: drop TARGET_UBUNTU
TARGET_UBUNTU is effectively the same as TARGET_DEBIAN. Given the Ubuntu
is unlikely to use systemd anytime soon there's no point in keeping this
separate.
2012-11-24 00:24:46 +01:00
Lennart Poettering 92134489ab time-util: teach parse_timestamp to parse weekdays 2012-11-23 22:52:46 +01:00
Lennart Poettering 6a741b4a2b path-util: when parsing a timestamp we don't know the timezone 2012-11-23 22:52:38 +01:00
Lennart Poettering 9185c8e626 time-util: also rename FORMAT_TIMESTAMP_PRETTY → _MAX 2012-11-23 22:51:55 +01:00
Lennart Poettering decad9103e util: teach parse_timestamp() to parse results of format_timestamp_relative() 2012-11-23 22:20:15 +01:00
Lennart Poettering bbb8486e17 util: rename format_timestamp_pretty() to format_timestamp_relative() because that describes much better what it does 2012-11-23 22:12:59 +01:00
Lennart Poettering 9a98c7a156 util: split off time related calls from util.[ch] into time-util.[ch] 2012-11-23 22:07:24 +01:00
Lennart Poettering aaa870928f test: extend calendarspec test a bit 2012-11-23 21:50:51 +01:00