picnoir/Nix
1
0
Fork 0
Code Issues Pull requests 1 Releases Wiki Activity

ExprCall::eval: Heap allocate at arity 5+

Browse source
This commit is contained in:
Robert Hensing 2023-11-16 12:44:10 +01:00
parent 206ece0f41
commit 91114a6fa4
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/libexpr/eval.cc
View file

@ -1766,8 +1766,13 @@ void ExprCall::eval(EvalState & state, Env & env, Value & v)
Value vFun;
fun->eval(state, env, vFun);
boost::container::small_vector<Value *, 64> vArgs(args.size());
// Empirical arity of Nixpkgs lambdas by regex e.g. ([a-zA-Z]+:(\s|(/\*.*\/)|(#.*\n))*){5}
// 2: over 4000
// 3: about 300
// 4: about 60
// 5: under 10
// This excluded attrset lambdas (`{...}:`). Contributions of mixed lambdas appears insignificant at ~150 total.
boost::container::small_vector<Value *, 4> vArgs(args.size());
for (size_t i = 0; i < args.size(); ++i)
vArgs[i] = args[i]->maybeThunk(state, env);