picnoir/Nix
1
0
Fork 0
Code Issues Pull requests 1 Releases Wiki Activity

Use a proper enum rather than a boolean in runProgramInStore

Browse source 
Makes the call-site much easier to understand.
This commit is contained in:
Théophane Hufschmitt 2023-12-01 15:35:21 +01:00
parent 743232bf04
commit ea2dd16623
4 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/nix/develop.cc
View file

@ -662,7 +662,7 @@ struct CmdDevelop : Common, MixEnvironment
}
}
runProgramInStore(store, true, shell, args, buildEnvironment.getSystem());
runProgramInStore(store, UseSearchPath::Use, shell, args, buildEnvironment.getSystem());
}
};

2
src/nix/fmt.cc
View file

@ -49,7 +49,7 @@ struct CmdFmt : SourceExprCommand {
}
}
runProgramInStore(store, false, app.program, programArgs);
runProgramInStore(store, UseSearchPath::DontUse, app.program, programArgs);
};
};

8
src/nix/run.cc
View file

@ -25,7 +25,7 @@ std::string chrootHelperName = "__run_in_chroot";
namespace nix {
void runProgramInStore(ref<Store> store,
bool search,
UseSearchPath useSearchPath,
const std::string & program,
const Strings & args,
std::optional<std::string_view> system)
@ -59,7 +59,7 @@ void runProgramInStore(ref<Store> store,
if (system)
setPersonality(*system);
if (search)
if (useSearchPath == UseSearchPath::Use)
execvp(program.c_str(), stringsToCharPtrs(args).data());
else
execv(program.c_str(), stringsToCharPtrs(args).data());
@ -136,7 +136,7 @@ struct CmdShell : InstallablesCommand, MixEnvironment
Strings args;
for (auto & arg : command) args.push_back(arg);
runProgramInStore(store, true, *command.begin(), args);
runProgramInStore(store, UseSearchPath::Use, *command.begin(), args);
}
};
@ -198,7 +198,7 @@ struct CmdRun : InstallableValueCommand
Strings allArgs{app.program};
for (auto & i : args) allArgs.push_back(i);
runProgramInStore(store, false, app.program, allArgs);
runProgramInStore(store, UseSearchPath::DontUse, app.program, allArgs);
}
};

7
src/nix/run.hh
View file

@ -5,8 +5,13 @@
namespace nix {
enum struct UseSearchPath {
Use,
DontUse
};
void runProgramInStore(ref<Store> store,
bool search,
UseSearchPath useSearchPath,
const std::string & program,
const Strings & args,
std::optional<std::string_view> system = std::nullopt);