cb7fbd4d83
Print value on type error
...
Adds the failing value to `value is <TYPE> while a <TYPE> is expected`
error messages.
2024-01-22 08:56:02 -08:00
b74ec56da9
Merge pull request #9829 from obsidiansystems/fix-if-if-else-ambiguity
...
If `if`...`if`...`else` ambiguity
2024-01-22 10:58:46 -05:00
316e50cc7c
Fix `if`...`if`...`else` ambiguity
...
This can be parsed two ways. Add a pair of braces so it must be parsed
the intended way.
2024-01-22 10:33:40 -05:00
176dcd5c61
Merge pull request #9626 from jvns/locked-input
...
Make fetchTree locked input error message clearer
2024-01-22 09:31:59 -05:00
80b84710b8
Update src/libexpr/eval.cc
...
Co-authored-by: John Ericson <git@JohnEricson.me>
2024-01-22 15:15:53 +01:00
16ccca2e86
Merge pull request #9703 from fricklerhandwerk/upgrade-no-channel
...
don't show `nix-channel` in upgrade instructions
2024-01-22 14:46:47 +01:00
0bcdb4f5f0
Elaborate what the monthly assignments status check entails
...
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2024-01-22 08:38:52 -05:00
b2066c3574
Merge pull request #9521 from fricklerhandwerk/conf-reword-max-jobs
...
reword description of the `max-jobs` setting
2024-01-22 08:29:12 -05:00
a0b86b3160
Merge pull request #9760 from hercules-ci/doc-glossary-nix-expression
...
doc/glossary: Nix expression can be language expression
2024-01-22 08:26:01 -05:00
c8d33bca8d
Merge pull request #9822 from obsidiansystems/algo-vs-hash-algo
...
Start standardizing hash algo flags
2024-01-22 11:08:24 +01:00
f51409cf98
Merge pull request #9805 from yshui/prefetch-unpack
...
Add --unpack to nix store prefetch-file
2024-01-22 10:51:50 +01:00
da1aae2d06
Merge pull request #9821 from obsidiansystems/fix-typo
...
Fix typo in upcomming release notes
2024-01-20 18:03:25 -05:00
202c5e2afc
Start standardizing hash algo flags
...
Do this if we want to do `--hash-algo` everywhere, and not `--algo` for
hash commands.
The new `nix hash convert` is updated. Deprecated new CLI commands are
left as-is (`nix hash path` needs to be redone and is also left as-is).
2024-01-20 17:29:35 -05:00
a93b204c27
Merge pull request #9348 from obsidiansystems/json-formats
...
Document JSON formats
2024-01-20 17:22:39 -05:00
65294fe5fe
Fix typo in upcomming release notes
...
Thanks @cole-h for finding in https://github.com/NixOS/nix/pull/9815#discussion_r1460604130
2024-01-20 17:07:21 -05:00
edf3ecc497
Document JSON formats
...
Good to document these formats separately from commands that happen to
use them.
Eventually I would like this and `builtins.derivation` to refer to a
store section on derivations that is authoritative, but that doesn't yet
exist, and will take some time to make. So I think we're just best off
merging this now as is.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2024-01-20 17:03:47 -05:00
561a56cd13
Add release notes
2024-01-20 00:04:06 -08:00
d75a5f427a
Print how many checks are run
2024-01-20 00:04:06 -08:00
9404ce36e4
Print derivation paths
...
Also be more consistent with quotes around attribute paths
2024-01-20 00:04:05 -08:00
49221493e2
Log what `nix flake check` does
...
There's still room for improvement, but this produces much more
informative output with `-v`:
```
$ nix flake check -v
evaluating flake...
checking flake output 'checks'...
checking derivation checks.aarch64-darwin.ghcid-ng-tests...
checking derivation checks.aarch64-darwin.ghcid-ng-clippy...
checking derivation checks.aarch64-darwin.ghcid-ng-doc...
checking derivation checks.aarch64-darwin.ghcid-ng-fmt...
checking derivation checks.aarch64-darwin.ghcid-ng-audit...
checking flake output 'packages'...
checking derivation packages.aarch64-darwin.ghcid-ng...
checking derivation packages.aarch64-darwin.ghcid-ng-tests...
checking derivation packages.aarch64-darwin.default...
checking flake output 'apps'...
checking flake output 'devShells'...
checking derivation devShells.aarch64-darwin.default...
running flake checks...
warning: The check omitted these incompatible systems: aarch64-linux, x86_64-darwin, x86_64-linux
Use '--all-systems' to check all.
```
2024-01-20 00:02:35 -08:00
9b896bf7e9
Merge pull request #9809 from obsidiansystems/nix-store-add-algo
...
Add missing `--hash-algo` flag to `nix store add`
2024-01-19 23:37:11 -05:00
356352c370
Add missing `--hash-algo` flag to `nix store add`
2024-01-19 23:11:18 -05:00
382fa51ff0
Merge pull request #9794 from hercules-ci/queryPathInfoFromClientCache
...
refactor: Extract `Store::queryPathInfoFromClientCache`
2024-01-19 17:33:52 +01:00
d19627e8b4
refactor: Remove throw from queryPathInfoFromClientCache
...
Return a value instead of throwing.
Rather than the more trivial refactor of wrapping the return value in
another std::optional, we retain the meaning of the outer optional:
"we know at least something."
So we have changed:
return nullopt -> return nullopt
throw InvalidPath -> return make_optional(nullptr)
return vpi -> return make_optional(vpi)
2024-01-19 17:01:19 +01:00
8983ee8b2e
refactor: Un-callback transform Store::queryPathInfoFromClientCache
...
This part of the code was not necessarily callback based.
Removing CPS is always nice; particularly if there's no loss of
functionality, like here.
2024-01-19 17:01:19 +01:00
75a6e6dd0e
Add --unpack to nix store prefetch-file
2024-01-19 15:53:45 +00:00
e6e160a075
Merge pull request #9632 from cole-h/nix-daemon-testing
...
Use `nix daemon` in the test suite
2024-01-19 16:21:51 +01:00
10165c7593
Merge pull request #9811 from DavHau/fix-git-auth
...
fetchTree/fetchGit: re-enable shallow fetching
2024-01-19 16:14:41 +01:00
57d6284eb7
Merge pull request #9812 from NixOS/remove-n-shorthand-for---mode
...
Remove a nonsensical shorthand flag in `nix store add`
2024-01-19 08:34:43 -05:00
bc00fa4647
fetchTree/fetchGit: re-enable shallow fetching
...
Add several tests for git fetching:
- shallow-cache-separation: can fetch the same repo shallowly and non-shallowly
- shallow-ignore-ref: ensure that ref gets ignored when shallow=true is set
- ssh-shallow: can fetch a git repo via ssh using shallow=1
2024-01-19 20:30:47 +07:00
d762caff46
Merge pull request #9806 from hercules-ci/fix-git-auth
...
Fix git auth
2024-01-19 13:47:52 +01:00
28d7db249a
Remove a nonsensical shorthand flag in `nix store add`
...
`-n` was an alias for `--mode`, but that seems to just be a copy-paste error as it doesn't make sense.
`--mode` probably doesn't need a shorthand flag at all, so remove it.
Noticed in https://github.com/NixOS/nix/pull/9809#issuecomment-1899890555
2024-01-19 10:10:00 +01:00
3b20cca962
Merge pull request #9804 from edolstra/missing-nar-crash
...
Fix crash when NAR is missing from binary cache
2024-01-19 09:38:53 +01:00
4e8483d09d
Merge pull request #9792 from fricklerhandwerk/move-section
...
move section on make variables
2024-01-19 00:55:33 +01:00
14f470ec4e
doc/hacking.md: Hint short option `make -e`
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2024-01-19 00:32:30 +01:00
346d513d86
tests/nixos/fetch-git: Add http-auth test
2024-01-18 22:34:38 +01:00
8d422c2fef
Revert libgit2 fetching
...
libgit2 is not capable of using git-credentials helpers yet.
This prevents private repositories from being used.
Based on code that was replaced in https://github.com/NixOS/nix/pull/9240
(Introduce libgit2); hence:
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2024-01-18 22:29:26 +01:00
76a50b3a69
doc: GitRepoImpl::path
2024-01-18 22:29:26 +01:00
ed975e953c
tests/nixos/fetch-git: Testsupport for private repos
2024-01-18 22:29:26 +01:00
0bd9e10aea
Merge pull request #9676 from DavHau/git-testsuite
...
initialize test suite for git fetchers
2024-01-18 21:51:48 +01:00
1254170405
tests/nixos/fetch-git: Make the store paths unique
2024-01-18 21:00:40 +01:00
94eba0ebbb
tests/nixos/fetch-git: Memoize -> save
...
Memoization is for thunk-like behavior whereas this is executed eagerly.
2024-01-18 21:00:40 +01:00
fd41979d78
tests/nixos/fetch-git: Factor out gitea repo module
2024-01-18 21:00:40 +01:00
dca0a80240
copyStorePath(): Bail out early if the store path already exists
...
In rare cases (e.g. when using allowSubstitutes = false), it's
possible that we simultaneously have a DerivationGoal *and* a
SubstitutionGoal building the same path. So if a DerivationGoal
already built the path while the SubstitutionGoal was waiting for a
download slot, it saves us a superfluous download to exit early.
2024-01-18 17:19:15 +01:00
a18d8d688a
LocalStore::addToStore(): Ignore exceptions from parseDump()
...
In the "discard" case (i.e. when the store path already exists
locally), when we call parseDump() from a Finally and it throws an
exception (e.g. if the download of the NAR fails), Nix crashes:
terminate called after throwing an instance of 'nix::SubstituteGone'
what(): error: file 'nar/06br3254rx4gz4cvjzxlv028jrx80zg5i4jr62vjmn416dqihgr7.nar.xz' does not exist in binary cache 'http://localhost '
Aborted (core dumped)
2024-01-18 17:19:15 +01:00
ab786e22f1
Show what goal is waiting for a build slot
2024-01-18 17:19:15 +01:00
e652322a61
Merge pull request #9799 from obsidiansystems/push-add-to-store-from-dump-unsupported-down
...
Push `addToStoreFromDump` `unsupported(...)` down `Store` class hierarchy
2024-01-18 16:54:44 +01:00
32706b14a7
Merge pull request #9798 from edolstra/remote-store-eof
...
Print a more helpful message if the daemon crashes
2024-01-18 15:47:59 +01:00
1fe8f54bd3
Use BackedStringView
2024-01-18 15:27:57 +01:00
78074bdea4
tests/nixos/fetch-git: Apply suggestions
2024-01-18 12:53:53 +01:00
Rebecca Turner