picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
Systemd/src/test/test-clock.c

79 lines
2.6 KiB
C
Raw Normal View History

license: LGPL-2.1+ -> LGPL-2.1-or-later
2020-11-09 05:23:58 +01:00
/* SPDX-License-Identifier: LGPL-2.1-or-later */
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
/***
tree-wide: use proper unicode © instead of (C) where we can Let's use a proper unicode copyright symbol where we can, it's prettier. This important patch is very important.
2018-06-12 17:15:23 +02:00
Copyright © 2016 Canonical Ltd.
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
***/
#include <unistd.h>
#include <fcntl.h>
test-clock: fix fd "leak" CID #1352301.
2016-02-29 14:03:32 +01:00
#include "clock-util.h"
#include "fd-util.h"
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
#include "fileio.h"
Introduce fmkostemp_safe and use it in tests No functional change.
2018-10-23 10:50:09 +02:00
#include "fs-util.h"
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
#include "log.h"
test-clock: fix fd "leak" CID #1352301.
2016-02-29 14:03:32 +01:00
#include "macro.h"
util-lib: split out all temporary file related calls into tmpfiles-util.c This splits out a bunch of functions from fileio.c that have to do with temporary files. Simply to make the header files a bit shorter, and to group things more nicely. No code changes, just some rearranging of source files.
2018-11-30 21:05:27 +01:00
#include "tmpfile-util.h"
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
static void test_clock_is_localtime(void) {
test: _cleanup_(unlink_tempfilep) in two more places
2018-10-23 10:50:38 +02:00
_cleanup_(unlink_tempfilep) char adjtime[] = "/tmp/test-adjtime.XXXXXX";
test-clock: fix FILE* leak Close the FILE* instead of the underlying fd.
2016-02-29 17:40:08 +01:00
_cleanup_fclose_ FILE* f = NULL;
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
test-clock: fix fd "leak" CID #1352301.
2016-02-29 14:03:32 +01:00
static const struct scenario {
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
const char* contents;
int expected_result;
} scenarios[] = {
/* adjtime configures UTC */
{"0.0 0 0\n0\nUTC\n", 0},
/* adjtime configures local time */
{"0.0 0 0\n0\nLOCAL\n", 1},
/* no final EOL */
{"0.0 0 0\n0\nUTC", 0},
{"0.0 0 0\n0\nLOCAL", 1},
clock-util: be more tolerant in parsing /etc/adjtime As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it also makes sense to have that default if /etc/adjtime contains only one or two lines. Drop the "gibberish" test case, as this was just EIO because of not containing three lines, which is already contained in other tests. clock_is_localtime() never actually validated the format of the first two lines, and there is little point in doing that. This addresses the reading half of issue #2638.
2016-02-26 12:33:41 +01:00
/* empty value -> defaults to UTC */
{"0.0 0 0\n0\n", 0},
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
/* unknown value -> defaults to UTC */
{"0.0 0 0\n0\nFOO\n", 0},
clock-util: be more tolerant in parsing /etc/adjtime As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it also makes sense to have that default if /etc/adjtime contains only one or two lines. Drop the "gibberish" test case, as this was just EIO because of not containing three lines, which is already contained in other tests. clock_is_localtime() never actually validated the format of the first two lines, and there is little point in doing that. This addresses the reading half of issue #2638.
2016-02-26 12:33:41 +01:00
/* no third line */
{"0.0 0 0", 0},
{"0.0 0 0\n", 0},
{"0.0 0 0\n0", 0},
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
};
/* without an adjtime file we default to UTC */
assert_se(clock_is_localtime("/nonexisting/adjtime") == 0);
Introduce fmkostemp_safe and use it in tests No functional change.
2018-10-23 10:50:09 +02:00
assert_se(fmkostemp_safe(adjtime, "w", &f) == 0);
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
log_info("adjtime test file: %s", adjtime);
for (size_t i = 0; i < ELEMENTSOF(scenarios); ++i) {
log_info("scenario #%zu:, expected result %i", i, scenarios[i].expected_result);
log_info("%s", scenarios[i].contents);
rewind(f);
Fix clang-11 issues Tested with clang 11.0.0-++20200715043845+0e377e253c1-1~exp1 on Debian sid ../src/network/test-networkd-conf.c:104:56: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] test_config_parse_duid_rawdata_one(BYTES_0_128 + 2, 0, &(DUID){0, 128, BYTES_1_128}); ~~~~~~~~~~~~^~~ ../src/network/test-networkd-conf.c:104:56: note: use array indexing to silence this warning test_config_parse_duid_rawdata_one(BYTES_0_128 + 2, 0, &(DUID){0, 128, BYTES_1_128}); ^ & [ ] 1 warning generated. ../src/test/test-clock.c:52:17: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] ftruncate(fileno(f), 0); ^~~~~~~~~ ~~~~~~~~~~~~ 1 warning generated. (gdb) run Starting program: systemd/build/test-alloc-util [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". x1: 0x7fffffffd2d0 x2: 0x7fffffffdac0 y: 0x7fffffffd2cc z: 0x7fffffffd2c0 cleanup2(0x7fffffffd2cc) cleanup3(0x7fffffffd2c0) cleanup1(0x7fffffffdac0) cleanup1(0x7fffffffd2d0) *** buffer overflow detected ***: terminated Program received signal SIGABRT, Aborted. __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) bt full set = {__val = {0, 18446744073709551615, 0, 0, 0, 0, 140737348658240, 140737348659520, 0, 0, 0, 0, 0, 0, 0, 0}} pid = <optimized out> tid = <optimized out> ret = <optimized out> save_stage = 1 act = {__sigaction_handler = {sa_handler = 0x22ff0, sa_sigaction = 0x22ff0}, sa_mask = {__val = {140737349888603, 4217127, 4217127, 4217127, 4217127, 4217383, 0, 0, 0, 0, 143329, 143344, 140737351162752, 8959, 18446744073709551328, 4289072}}, sa_flags = -138460788, sa_restorer = 0xffffffffffffffff} sigs = {__val = {32, 0 <repeats 15 times>}} ap = {{gp_offset = 24, fp_offset = 0, overflow_arg_area = 0x7fffffffd280, reg_save_area = 0x7fffffffd210}} fd = <optimized out> list = <optimized out> nlist = <optimized out> cp = <optimized out> No locals. No locals. No locals. No locals. No locals. l = 0 No locals. p1 = 0x405500 "\223Nd\n\351\301mA\214\262A\247\306b\276\317\327\353\346k\035\024\273{\276&!kλ\233\217\t\207\276\327\347\351\355\307R\276\063{\235w=\237E\357\277KL\245\374\245\066M\201+\333\064\272\332g>1<@" p2 = <optimized out> i = <optimized out> No locals.
2020-07-25 18:23:11 +02:00
assert_se(ftruncate(fileno(f), 0) == 0);
fileio: make write_string_stream() accept flags parameter Let's make write_string_stream() and write_string_file() more alike, and pass the same flag set so that we can remove a number of boolean parameters.
2017-09-22 20:55:34 +02:00
assert_se(write_string_stream(f, scenarios[i].contents, WRITE_STRING_FILE_AVOID_NEWLINE) == 0);
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
assert_se(clock_is_localtime(adjtime) == scenarios[i].expected_result);
}
}
/* Test with the real /etc/adjtime */
static void test_clock_is_localtime_system(void) {
int r;
r = clock_is_localtime(NULL);
tests: various small fixes for strict systems Don't assume that 4MB can be allocated from stack since there could be smaller DefaultLimitSTACK= in force, so let's use malloc(). NUL terminate the huge strings by hand, also ensure termination in test_lz4_decompress_partial() and optimize the memset() for the string. Some items in /proc and /etc may not be accessible to poor unprivileged users due to e.g. SELinux, BOFH or both, so check for EACCES and EPERM. /var/tmp may be a symlink to /tmp and then path_compare() will always fail, so let's stick to /tmp like elsewhere. /tmp may be mounted with noexec option and then trying to execute scripts from there would fail. Detect and warn if seccomp is already in use, which could make seccomp test fail if the syscalls are already blocked. Unset $TMPDIR so it will not break specifier tests where %T is assumed to be /tmp and %V /var/tmp.
2020-04-23 12:12:23 +02:00
if (access("/etc/adjtime", R_OK) == 0) {
log_info("/etc/adjtime is readable, clock_is_localtime() == %i", r);
clock-util: be more tolerant in parsing /etc/adjtime As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it also makes sense to have that default if /etc/adjtime contains only one or two lines. Drop the "gibberish" test case, as this was just EIO because of not containing three lines, which is already contained in other tests. clock_is_localtime() never actually validated the format of the first two lines, and there is little point in doing that. This addresses the reading half of issue #2638.
2016-02-26 12:33:41 +01:00
/* if /etc/adjtime exists we expect some answer, no error or
* crash */
tree-wide: use IN_SET macro (#6977)
2017-10-04 16:01:32 +02:00
assert_se(IN_SET(r, 0, 1));
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
} else
/* default is UTC if there is no /etc/adjtime */
tests: various small fixes for strict systems Don't assume that 4MB can be allocated from stack since there could be smaller DefaultLimitSTACK= in force, so let's use malloc(). NUL terminate the huge strings by hand, also ensure termination in test_lz4_decompress_partial() and optimize the memset() for the string. Some items in /proc and /etc may not be accessible to poor unprivileged users due to e.g. SELinux, BOFH or both, so check for EACCES and EPERM. /var/tmp may be a symlink to /tmp and then path_compare() will always fail, so let's stick to /tmp like elsewhere. /tmp may be mounted with noexec option and then trying to execute scripts from there would fail. Detect and warn if seccomp is already in use, which could make seccomp test fail if the syscalls are already blocked. Unset $TMPDIR so it will not break specifier tests where %T is assumed to be /tmp and %V /var/tmp.
2020-04-23 12:12:23 +02:00
assert_se(r == 0 || ERRNO_IS_PRIVILEGE(r));
clock-util: make clock_is_localtime() testable and add initial tests Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26 11:25:22 +01:00
}
int main(int argc, char *argv[]) {
test_clock_is_localtime();
test_clock_is_localtime_system();
return 0;
}
Reference in a new issue Copy permalink