Systemd/src/shutdown/umount.c

840 lines
28 KiB
C
Raw Normal View History

/* SPDX-License-Identifier: LGPL-2.1-or-later */
/***
Copyright © 2010 ProFUSION embedded systems
***/
#include <errno.h>
#include <fcntl.h>
#include <linux/dm-ioctl.h>
#include <linux/major.h>
#include <linux/raid/md_u.h>
#include <linux/loop.h>
#include <sys/mount.h>
#include <sys/swap.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <unistd.h>
#include "sd-device.h"
#include "alloc-util.h"
#include "blockdev-util.h"
#include "def.h"
#include "device-util.h"
#include "escape.h"
#include "fd-util.h"
#include "fs-util.h"
#include "fstab-util.h"
#include "libmount-util.h"
#include "mount-setup.h"
#include "mount-util.h"
Split out part of mount-util.c into mountpoint-util.c The idea is that anything which is related to actually manipulating mounts is in mount-util.c, but functions for mountpoint introspection are moved to the new file. Anything which requires libmount must be in mount-util.c. This was supposed to be a preparation for further changes, with no functional difference, but it results in a significant change in linkage: $ ldd build/libnss_*.so.2 (before) build/libnss_myhostname.so.2: linux-vdso.so.1 (0x00007fff77bf5000) librt.so.1 => /lib64/librt.so.1 (0x00007f4bbb7b2000) libmount.so.1 => /lib64/libmount.so.1 (0x00007f4bbb755000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f4bbb734000) libc.so.6 => /lib64/libc.so.6 (0x00007f4bbb56e000) /lib64/ld-linux-x86-64.so.2 (0x00007f4bbb8c1000) libblkid.so.1 => /lib64/libblkid.so.1 (0x00007f4bbb51b000) libuuid.so.1 => /lib64/libuuid.so.1 (0x00007f4bbb512000) libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f4bbb4e3000) libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007f4bbb45e000) libdl.so.2 => /lib64/libdl.so.2 (0x00007f4bbb458000) build/libnss_mymachines.so.2: linux-vdso.so.1 (0x00007ffc19cc0000) librt.so.1 => /lib64/librt.so.1 (0x00007fdecb74b000) libcap.so.2 => /lib64/libcap.so.2 (0x00007fdecb744000) libmount.so.1 => /lib64/libmount.so.1 (0x00007fdecb6e7000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fdecb6c6000) libc.so.6 => /lib64/libc.so.6 (0x00007fdecb500000) /lib64/ld-linux-x86-64.so.2 (0x00007fdecb8a9000) libblkid.so.1 => /lib64/libblkid.so.1 (0x00007fdecb4ad000) libuuid.so.1 => /lib64/libuuid.so.1 (0x00007fdecb4a2000) libselinux.so.1 => /lib64/libselinux.so.1 (0x00007fdecb475000) libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007fdecb3f0000) libdl.so.2 => /lib64/libdl.so.2 (0x00007fdecb3ea000) build/libnss_resolve.so.2: linux-vdso.so.1 (0x00007ffe8ef8e000) librt.so.1 => /lib64/librt.so.1 (0x00007fcf314bd000) libcap.so.2 => /lib64/libcap.so.2 (0x00007fcf314b6000) libmount.so.1 => /lib64/libmount.so.1 (0x00007fcf31459000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fcf31438000) libc.so.6 => /lib64/libc.so.6 (0x00007fcf31272000) /lib64/ld-linux-x86-64.so.2 (0x00007fcf31615000) libblkid.so.1 => /lib64/libblkid.so.1 (0x00007fcf3121f000) libuuid.so.1 => /lib64/libuuid.so.1 (0x00007fcf31214000) libselinux.so.1 => /lib64/libselinux.so.1 (0x00007fcf311e7000) libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007fcf31162000) libdl.so.2 => /lib64/libdl.so.2 (0x00007fcf3115c000) build/libnss_systemd.so.2: linux-vdso.so.1 (0x00007ffda6d17000) librt.so.1 => /lib64/librt.so.1 (0x00007f610b83c000) libcap.so.2 => /lib64/libcap.so.2 (0x00007f610b835000) libmount.so.1 => /lib64/libmount.so.1 (0x00007f610b7d8000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f610b7b7000) libc.so.6 => /lib64/libc.so.6 (0x00007f610b5f1000) /lib64/ld-linux-x86-64.so.2 (0x00007f610b995000) libblkid.so.1 => /lib64/libblkid.so.1 (0x00007f610b59e000) libuuid.so.1 => /lib64/libuuid.so.1 (0x00007f610b593000) libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f610b566000) libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007f610b4e1000) libdl.so.2 => /lib64/libdl.so.2 (0x00007f610b4db000) (after) build/libnss_myhostname.so.2: linux-vdso.so.1 (0x00007fff0b5e2000) librt.so.1 => /lib64/librt.so.1 (0x00007fde0c328000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fde0c307000) libc.so.6 => /lib64/libc.so.6 (0x00007fde0c141000) /lib64/ld-linux-x86-64.so.2 (0x00007fde0c435000) build/libnss_mymachines.so.2: linux-vdso.so.1 (0x00007ffdc30a7000) librt.so.1 => /lib64/librt.so.1 (0x00007f06ecabb000) libcap.so.2 => /lib64/libcap.so.2 (0x00007f06ecab4000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f06eca93000) libc.so.6 => /lib64/libc.so.6 (0x00007f06ec8cd000) /lib64/ld-linux-x86-64.so.2 (0x00007f06ecc15000) build/libnss_resolve.so.2: linux-vdso.so.1 (0x00007ffe95747000) librt.so.1 => /lib64/librt.so.1 (0x00007fa56a80f000) libcap.so.2 => /lib64/libcap.so.2 (0x00007fa56a808000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fa56a7e7000) libc.so.6 => /lib64/libc.so.6 (0x00007fa56a621000) /lib64/ld-linux-x86-64.so.2 (0x00007fa56a964000) build/libnss_systemd.so.2: linux-vdso.so.1 (0x00007ffe67b51000) librt.so.1 => /lib64/librt.so.1 (0x00007ffb32113000) libcap.so.2 => /lib64/libcap.so.2 (0x00007ffb3210c000) libpthread.so.0 => /lib64/libpthread.so.0 (0x00007ffb320eb000) libc.so.6 => /lib64/libc.so.6 (0x00007ffb31f25000) /lib64/ld-linux-x86-64.so.2 (0x00007ffb3226a000) I don't quite understand what is going on here, but let's not be too picky.
2018-11-29 10:24:39 +01:00
#include "mountpoint-util.h"
2012-05-07 21:36:12 +02:00
#include "path-util.h"
#include "process-util.h"
#include "signal-util.h"
#include "string-util.h"
#include "strv.h"
#include "umount.h"
#include "util.h"
#include "virt.h"
static void mount_point_free(MountPoint **head, MountPoint *m) {
assert(head);
assert(m);
LIST_REMOVE(mount_point, *head, m);
free(m->path);
free(m->remount_options);
free(m);
}
void mount_points_list_free(MountPoint **head) {
assert(head);
while (*head)
mount_point_free(head, *head);
}
int mount_points_list_get(const char *mountinfo, MountPoint **head) {
_cleanup_(mnt_free_tablep) struct libmnt_table *table = NULL;
_cleanup_(mnt_free_iterp) struct libmnt_iter *iter = NULL;
int r;
assert(head);
r = libmount_parse(mountinfo, NULL, &table, &iter);
if (r < 0)
return log_error_errno(r, "Failed to parse %s: %m", mountinfo ?: "/proc/self/mountinfo");
for (;;) {
struct libmnt_fs *fs;
const char *path, *fstype;
_cleanup_free_ char *options = NULL;
unsigned long remount_flags = 0u;
_cleanup_free_ char *remount_options = NULL;
bool try_remount_ro;
_cleanup_free_ MountPoint *m = NULL;
r = mnt_table_next_fs(table, iter, &fs);
if (r == 1)
break;
if (r < 0)
return log_error_errno(r, "Failed to get next entry from %s: %m", mountinfo ?: "/proc/self/mountinfo");
path = mnt_fs_get_target(fs);
if (!path)
continue;
fstype = mnt_fs_get_fstype(fs);
/* Combine the generic VFS options with the FS-specific
* options. Duplicates are not a problem here, because the only
* options that should come up twice are typically ro/rw, which
* are turned into MS_RDONLY or the inversion of it.
*
* Even if there are duplicates later in mount_option_mangle()
* they shouldn't hurt anyways as they override each other.
*/
if (!strextend_with_separator(&options, ",", mnt_fs_get_vfs_options(fs)))
return log_oom();
if (!strextend_with_separator(&options, ",", mnt_fs_get_fs_options(fs)))
return log_oom();
/* Ignore mount points we can't unmount because they
* are API or because we are keeping them open (like
* /dev/console). Also, ignore all mounts below API
* file systems, since they are likely virtual too,
* and hence not worth spending time on. Also, in
* unprivileged containers we might lack the rights to
* unmount these things, hence don't bother. */
if (mount_point_is_api(path) ||
mount_point_ignore(path) ||
PATH_STARTSWITH_SET(path, "/dev", "/sys", "/proc"))
continue;
/* If we are in a container, don't attempt to
* read-only mount anything as that brings no real
* benefits, but might confuse the host, as we remount
* the superblock here, not the bind mount.
*
* If the filesystem is a network fs, also skip the
* remount. It brings no value (we cannot leave
* a "dirty fs") and could hang if the network is down.
* Note that umount2() is more careful and will not
* hang because of the network being down. */
try_remount_ro = detect_container() <= 0 &&
!fstype_is_network(fstype) &&
!fstype_is_api_vfs(fstype) &&
!fstype_is_ro(fstype) &&
!fstab_test_yes_no_option(options, "ro\0rw\0");
if (try_remount_ro) {
/* mount(2) states that mount flags and options need to be exactly the same
* as they were when the filesystem was mounted, except for the desired
* changes. So we reconstruct both here and adjust them for the later
* remount call too. */
r = mnt_fs_get_propagation(fs, &remount_flags);
if (r < 0) {
log_warning_errno(r, "mnt_fs_get_propagation() failed for %s, ignoring: %m", path);
continue;
}
r = mount_option_mangle(options, remount_flags, &remount_flags, &remount_options);
if (r < 0) {
log_warning_errno(r, "mount_option_mangle failed for %s, ignoring: %m", path);
continue;
}
/* MS_BIND is special. If it is provided it will only make the mount-point
* read-only. If left out, the super block itself is remounted, which we want. */
remount_flags = (remount_flags|MS_REMOUNT|MS_RDONLY) & ~MS_BIND;
}
m = new0(MountPoint, 1);
if (!m)
return log_oom();
m->path = strdup(path);
if (!m->path)
return log_oom();
m->remount_options = TAKE_PTR(remount_options);
m->remount_flags = remount_flags;
m->try_remount_ro = try_remount_ro;
LIST_PREPEND(mount_point, *head, TAKE_PTR(m));
}
2014-06-05 21:35:15 +02:00
return 0;
}
int swap_list_get(const char *swaps, MountPoint **head) {
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
_cleanup_(mnt_free_tablep) struct libmnt_table *t = NULL;
_cleanup_(mnt_free_iterp) struct libmnt_iter *i = NULL;
int r;
assert(head);
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
t = mnt_new_table();
i = mnt_new_iter(MNT_ITER_FORWARD);
if (!t || !i)
return log_oom();
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
r = mnt_table_parse_swaps(t, swaps);
if (r == -ENOENT) /* no /proc/swaps is fine */
return 0;
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
if (r < 0)
return log_error_errno(r, "Failed to parse %s: %m", swaps ?: "/proc/swaps");
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
for (;;) {
struct libmnt_fs *fs;
_cleanup_free_ MountPoint *swap = NULL;
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
const char *source;
r = mnt_table_next_fs(t, i, &fs);
if (r == 1)
break;
if (r < 0)
return log_error_errno(r, "Failed to get next entry from %s: %m", swaps ?: "/proc/swaps");
core/umount: use libmount to enumerate /proc/swaps example.swaps with "(deleted)" does not cause bogus entries in the list now, but a memleak in libmount instead. The memleaks is not very important since this code is run just once. Reported as https://github.com/karelzak/util-linux/issues/596. $ build/test-umount ... /* test_swap_list("/proc/swaps") */ path=/var/tmp/swap o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 /* test_swap_list("/home/zbyszek/src/systemd/test/test-umount/example.swaps") */ path=/some/swapfile o= f=0x0 try-ro=no dev=0:0 path=/dev/dm-2 o= f=0x0 try-ro=no dev=0:0 ==26912== ==26912== HEAP SUMMARY: ==26912== in use at exit: 16 bytes in 1 blocks ==26912== total heap usage: 1,546 allocs, 1,545 frees, 149,008 bytes allocated ==26912== ==26912== 16 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==26912== at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==26912== by 0x55C5D8C: _IO_vfscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D8AEC: vsscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x55D25C3: sscanf (in /usr/lib64/libc-2.26.so) ==26912== by 0x53236D0: mnt_table_parse_stream (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x53249B6: mnt_table_parse_file (in /usr/lib64/libmount.so.1.1.0) ==26912== by 0x10D157: swap_list_get (umount.c:194) ==26912== by 0x10B06E: test_swap_list (test-umount.c:34) ==26912== by 0x10B24B: main (test-umount.c:56) ==26912== ==26912== LEAK SUMMARY: ==26912== definitely lost: 16 bytes in 1 blocks ==26912== indirectly lost: 0 bytes in 0 blocks ==26912== possibly lost: 0 bytes in 0 blocks ==26912== still reachable: 0 bytes in 0 blocks ==26912== suppressed: 0 bytes in 0 blocks
2018-03-14 12:22:27 +01:00
source = mnt_fs_get_source(fs);
if (!source)
continue;
swap = new0(MountPoint, 1);
if (!swap)
2019-11-15 14:58:06 +01:00
return log_oom();
swap->path = strdup(source);
if (!swap->path)
2019-11-15 14:58:06 +01:00
return log_oom();
LIST_PREPEND(mount_point, *head, TAKE_PTR(swap));
}
2014-06-24 19:00:32 +02:00
return 0;
}
static int loopback_list_get(MountPoint **head) {
_cleanup_(sd_device_enumerator_unrefp) sd_device_enumerator *e = NULL;
sd_device *d;
int r;
assert(head);
r = sd_device_enumerator_new(&e);
if (r < 0)
return r;
r = sd_device_enumerator_allow_uninitialized(e);
if (r < 0)
return r;
r = sd_device_enumerator_add_match_subsystem(e, "block", true);
if (r < 0)
return r;
r = sd_device_enumerator_add_match_sysname(e, "loop*");
if (r < 0)
return r;
r = sd_device_enumerator_add_match_sysattr(e, "loop/backing_file", NULL, true);
if (r < 0)
return r;
FOREACH_DEVICE(e, d) {
_cleanup_free_ char *p = NULL;
const char *dn;
MountPoint *lb;
dev_t devnum;
if (sd_device_get_devnum(d, &devnum) < 0 ||
sd_device_get_devname(d, &dn) < 0)
continue;
p = strdup(dn);
if (!p)
return -ENOMEM;
lb = new(MountPoint, 1);
2018-03-14 11:32:13 +01:00
if (!lb)
return -ENOMEM;
*lb = (MountPoint) {
.path = TAKE_PTR(p),
.devnum = devnum,
};
2018-03-14 11:32:13 +01:00
LIST_PREPEND(mount_point, *head, lb);
}
return 0;
}
static int dm_list_get(MountPoint **head) {
_cleanup_(sd_device_enumerator_unrefp) sd_device_enumerator *e = NULL;
sd_device *d;
int r;
2010-10-14 02:33:09 +02:00
assert(head);
r = sd_device_enumerator_new(&e);
if (r < 0)
return r;
2010-10-14 02:33:09 +02:00
r = sd_device_enumerator_allow_uninitialized(e);
if (r < 0)
return r;
2010-10-14 02:33:09 +02:00
r = sd_device_enumerator_add_match_subsystem(e, "block", true);
if (r < 0)
return r;
2010-10-14 02:33:09 +02:00
r = sd_device_enumerator_add_match_sysname(e, "dm-*");
if (r < 0)
return r;
2010-10-14 02:33:09 +02:00
FOREACH_DEVICE(e, d) {
_cleanup_free_ char *p = NULL;
const char *dn;
MountPoint *m;
dev_t devnum;
2010-10-14 02:33:09 +02:00
if (sd_device_get_devnum(d, &devnum) < 0 ||
sd_device_get_devname(d, &dn) < 0)
continue;
2010-10-14 02:33:09 +02:00
p = strdup(dn);
if (!p)
return -ENOMEM;
2010-10-14 02:33:09 +02:00
m = new(MountPoint, 1);
2018-03-14 11:32:13 +01:00
if (!m)
return -ENOMEM;
2010-10-14 02:33:09 +02:00
*m = (MountPoint) {
.path = TAKE_PTR(p),
.devnum = devnum,
};
2018-03-14 11:32:13 +01:00
LIST_PREPEND(mount_point, *head, m);
2010-10-14 02:33:09 +02:00
}
return 0;
2010-10-14 02:33:09 +02:00
}
static int md_list_get(MountPoint **head) {
_cleanup_(sd_device_enumerator_unrefp) sd_device_enumerator *e = NULL;
sd_device *d;
int r;
assert(head);
r = sd_device_enumerator_new(&e);
if (r < 0)
return r;
r = sd_device_enumerator_allow_uninitialized(e);
if (r < 0)
return r;
r = sd_device_enumerator_add_match_subsystem(e, "block", true);
if (r < 0)
return r;
r = sd_device_enumerator_add_match_sysname(e, "md*");
if (r < 0)
return r;
FOREACH_DEVICE(e, d) {
_cleanup_free_ char *p = NULL;
const char *dn;
MountPoint *m;
dev_t devnum;
if (sd_device_get_devnum(d, &devnum) < 0 ||
sd_device_get_devname(d, &dn) < 0)
continue;
p = strdup(dn);
if (!p)
return -ENOMEM;
m = new(MountPoint, 1);
if (!m)
return -ENOMEM;
*m = (MountPoint) {
.path = TAKE_PTR(p),
.devnum = devnum,
};
LIST_PREPEND(mount_point, *head, m);
}
return 0;
}
static int delete_loopback(const char *device) {
_cleanup_close_ int fd = -1;
struct loop_info64 info;
assert(device);
fd = open(device, O_RDONLY|O_CLOEXEC);
if (fd < 0) {
log_debug_errno(errno, "Failed to open loopback device %s: %m", device);
return errno == ENOENT ? 0 : -errno;
}
/* Loopback block devices don't sync in-flight blocks when we clear the fd, hence sync explicitly
* first */
if (fsync(fd) < 0)
log_debug_errno(errno, "Failed to sync loop block device %s, ignoring: %m", device);
if (ioctl(fd, LOOP_CLR_FD, 0) < 0) {
if (errno == ENXIO) /* Nothing bound, didn't do anything */
return 0;
if (errno != EBUSY)
return log_debug_errno(errno, "Failed to clear loopback device %s: %m", device);
if (ioctl(fd, LOOP_GET_STATUS64, &info) < 0) {
if (errno == ENXIO) /* What? Suddenly detached after all? That's fine by us then. */
return 1;
log_debug_errno(errno, "Failed to invoke LOOP_GET_STATUS64 on loopback device %s, ignoring: %m", device);
return -EBUSY; /* propagate original error */
}
if (FLAGS_SET(info.lo_flags, LO_FLAGS_AUTOCLEAR)) /* someone else already set LO_FLAGS_AUTOCLEAR for us? fine by us */
return -EBUSY; /* propagate original error */
info.lo_flags |= LO_FLAGS_AUTOCLEAR;
if (ioctl(fd, LOOP_SET_STATUS64, &info) < 0) {
if (errno == ENXIO) /* Suddenly detached after all? Fine by us */
return 1;
log_debug_errno(errno, "Failed to set LO_FLAGS_AUTOCLEAR flag for loop device %s, ignoring: %m", device);
} else
log_debug("Successfully set LO_FLAGS_AUTOCLEAR flag for loop device %s.", device);
return -EBUSY;
}
if (ioctl(fd, LOOP_GET_STATUS64, &info) < 0) {
/* If the LOOP_CLR_FD above succeeded we'll see ENXIO here. */
if (errno == ENXIO)
log_debug("Successfully detached loopback device %s.", device);
else
log_debug_errno(errno, "Failed to invoke LOOP_GET_STATUS64 on loopback device %s, ignoring: %m", device); /* the LOOP_CLR_FD at least worked, let's hope for the best */
return 1;
}
/* Linux makes LOOP_CLR_FD succeed whenever LO_FLAGS_AUTOCLEAR is set without actually doing
* anything. Very confusing. Let's hence not claim we did anything in this case. */
if (FLAGS_SET(info.lo_flags, LO_FLAGS_AUTOCLEAR))
log_debug("Successfully called LOOP_CLR_FD on a loopback device %s with autoclear set, which is a NOP.", device);
else
log_debug("Weird, LOOP_CLR_FD succeeded but the device is still attached on %s.", device);
return -EBUSY; /* Nothing changed, the device is still attached, hence it apparently is still busy */
}
static int delete_dm(MountPoint *m) {
2016-12-05 16:09:04 +01:00
_cleanup_close_ int fd = -1;
int r;
2016-12-05 16:09:04 +01:00
assert(m);
assert(major(m->devnum) != 0);
assert(m->path);
2010-10-14 02:33:09 +02:00
fd = open("/dev/mapper/control", O_RDWR|O_CLOEXEC);
if (fd < 0)
2010-10-14 02:33:09 +02:00
return -errno;
r = fsync_path_at(AT_FDCWD, m->path);
if (r < 0)
log_debug_errno(r, "Failed to sync DM block device %s, ignoring: %m", m->path);
if (ioctl(fd, DM_DEV_REMOVE, &(struct dm_ioctl) {
.version = {
DM_VERSION_MAJOR,
DM_VERSION_MINOR,
DM_VERSION_PATCHLEVEL
},
.data_size = sizeof(struct dm_ioctl),
.dev = m->devnum,
}) < 0)
2016-12-05 16:09:04 +01:00
return -errno;
return 0;
2010-10-14 02:33:09 +02:00
}
static int delete_md(MountPoint *m) {
_cleanup_close_ int fd = -1;
assert(m);
assert(major(m->devnum) != 0);
assert(m->path);
fd = open(m->path, O_RDONLY|O_CLOEXEC|O_EXCL);
if (fd < 0)
return -errno;
if (fsync(fd) < 0)
log_debug_errno(errno, "Failed to sync MD block device %s, ignoring: %m", m->path);
if (ioctl(fd, STOP_ARRAY, NULL) < 0)
return -errno;
return 0;
}
static bool nonunmountable_path(const char *path) {
return path_equal(path, "/")
#if ! HAVE_SPLIT_USR
|| path_equal(path, "/usr")
#endif
|| path_startswith(path, "/run/initramfs");
}
static int remount_with_timeout(MountPoint *m, int umount_log_level) {
pid_t pid;
int r;
BLOCK_SIGNALS(SIGCHLD);
assert(m);
2020-11-18 08:38:49 +01:00
/* Due to the possibility of a remount operation hanging, we fork a child process and set a
* timeout. If the timeout lapses, the assumption is that the particular remount failed. */
r = safe_fork("(sd-remount)", FORK_RESET_SIGNALS|FORK_CLOSE_ALL_FDS|FORK_LOG|FORK_REOPEN_LOG, &pid);
if (r < 0)
return r;
if (r == 0) {
log_info("Remounting '%s' read-only in with options '%s'.", m->path, m->remount_options);
/* Start the mount operation here in the child */
r = mount(NULL, m->path, NULL, m->remount_flags, m->remount_options);
if (r < 0)
log_full_errno(umount_log_level, errno, "Failed to remount '%s' read-only: %m", m->path);
_exit(r < 0 ? EXIT_FAILURE : EXIT_SUCCESS);
}
r = wait_for_terminate_with_timeout(pid, DEFAULT_TIMEOUT_USEC);
if (r == -ETIMEDOUT) {
log_error_errno(r, "Remounting '%s' timed out, issuing SIGKILL to PID " PID_FMT ".", m->path, pid);
(void) kill(pid, SIGKILL);
} else if (r == -EPROTO)
log_debug_errno(r, "Remounting '%s' failed abnormally, child process " PID_FMT " aborted or exited non-zero.", m->path, pid);
else if (r < 0)
log_error_errno(r, "Remounting '%s' failed unexpectedly, couldn't wait for child process " PID_FMT ": %m", m->path, pid);
return r;
}
static int umount_with_timeout(MountPoint *m, int umount_log_level) {
pid_t pid;
int r;
BLOCK_SIGNALS(SIGCHLD);
assert(m);
2020-11-18 08:38:49 +01:00
/* Due to the possibility of a umount operation hanging, we fork a child process and set a
* timeout. If the timeout lapses, the assumption is that the particular umount failed. */
r = safe_fork("(sd-umount)", FORK_RESET_SIGNALS|FORK_CLOSE_ALL_FDS|FORK_LOG|FORK_REOPEN_LOG, &pid);
if (r < 0)
return r;
if (r == 0) {
log_info("Unmounting '%s'.", m->path);
/* Start the mount operation here in the child Using MNT_FORCE
* causes some filesystems (e.g. FUSE and NFS and other network
* filesystems) to abort any pending requests and return -EIO
* rather than blocking indefinitely. If the filesysten is
* "busy", this may allow processes to die, thus making the
* filesystem less busy so the unmount might succeed (rather
* then return EBUSY).*/
r = umount2(m->path, MNT_FORCE);
if (r < 0)
log_full_errno(umount_log_level, errno, "Failed to unmount %s: %m", m->path);
_exit(r < 0 ? EXIT_FAILURE : EXIT_SUCCESS);
}
r = wait_for_terminate_with_timeout(pid, DEFAULT_TIMEOUT_USEC);
if (r == -ETIMEDOUT) {
log_error_errno(r, "Unmounting '%s' timed out, issuing SIGKILL to PID " PID_FMT ".", m->path, pid);
(void) kill(pid, SIGKILL);
} else if (r == -EPROTO)
log_debug_errno(r, "Unmounting '%s' failed abnormally, child process " PID_FMT " aborted or exited non-zero.", m->path, pid);
else if (r < 0)
log_error_errno(r, "Unmounting '%s' failed unexpectedly, couldn't wait for child process " PID_FMT ": %m", m->path, pid);
return r;
}
/* This includes remounting readonly, which changes the kernel mount options. Therefore the list passed to
* this function is invalidated, and should not be reused. */
static int mount_points_list_umount(MountPoint **head, bool *changed, int umount_log_level) {
core: systemd-shutdown: avoid confusingly redundant messages After previous output from systemd-shutdown indicated a bug, my attention was drawn to redundant output lines. Did they indicate an anomaly? It turns out to be an expected, harmless result of the current code. But we don't have much justification to run such redundant operations. Let's remove the confusing redundant message. We can stop trying to remount a directory read-only once its mount entry has successfully been changed to "ro". We can simply let the kernel keep track of this for us. I don't bother to try and avoid re-parsing the mountinfo. I appreciate snappy shutdowns, but this code is already intricate and buggy enough (see issue 7131). (Disclaimer: At least for the moment, you can't _rely_ on always seeing suspicious output from systemd-shutdown. By default, you can expect the kernel to truncate the log output of systemd-shutdown. Ick ick ick! Because /dev/kmsg is rate-limited by default. Normally it prints a message "X lines supressed", but we tend to shut down before the timer expires in this case). Before: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel... EXT4-fs (vda3): re-mounted. Opts: data=ordered systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered After: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered I also tested with `systemctl reboot --force`, plus a loopback mount to cause one of the umounts to fail initially. In this case another 2 lines of output are removed (out of a larger number of lines).
2017-10-19 16:02:12 +02:00
MountPoint *m;
int n_failed = 0;
assert(head);
assert(changed);
core: systemd-shutdown: avoid confusingly redundant messages After previous output from systemd-shutdown indicated a bug, my attention was drawn to redundant output lines. Did they indicate an anomaly? It turns out to be an expected, harmless result of the current code. But we don't have much justification to run such redundant operations. Let's remove the confusing redundant message. We can stop trying to remount a directory read-only once its mount entry has successfully been changed to "ro". We can simply let the kernel keep track of this for us. I don't bother to try and avoid re-parsing the mountinfo. I appreciate snappy shutdowns, but this code is already intricate and buggy enough (see issue 7131). (Disclaimer: At least for the moment, you can't _rely_ on always seeing suspicious output from systemd-shutdown. By default, you can expect the kernel to truncate the log output of systemd-shutdown. Ick ick ick! Because /dev/kmsg is rate-limited by default. Normally it prints a message "X lines supressed", but we tend to shut down before the timer expires in this case). Before: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel... EXT4-fs (vda3): re-mounted. Opts: data=ordered systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered After: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered I also tested with `systemctl reboot --force`, plus a loopback mount to cause one of the umounts to fail initially. In this case another 2 lines of output are removed (out of a larger number of lines).
2017-10-19 16:02:12 +02:00
LIST_FOREACH(mount_point, m, *head) {
if (m->try_remount_ro) {
/* We always try to remount directories read-only first, before we go on and umount
* them.
*
* Mount points can be stacked. If a mount point is stacked below / or /usr, we
* cannot umount or remount it directly, since there is no way to refer to the
* underlying mount. There's nothing we can do about it for the general case, but we
* can do something about it if it is aliased somewhere else via a bind mount. If we
* explicitly remount the super block of that alias read-only we hence should be
* relatively safe regarding keeping a dirty fs we cannot otherwise see.
*
* Since the remount can hang in the instance of remote filesystems, we remount
* asynchronously and skip the subsequent umount if it fails. */
if (remount_with_timeout(m, umount_log_level) < 0) {
/* Remount failed, but try unmounting anyway,
* unless this is a mount point we want to skip. */
if (nonunmountable_path(m->path)) {
n_failed++;
continue;
}
}
}
/* Skip / and /usr since we cannot unmount that anyway, since we are running from it. They
* have already been remounted ro. */
if (nonunmountable_path(m->path))
continue;
/* Trying to umount */
if (umount_with_timeout(m, umount_log_level) < 0)
n_failed++;
else
*changed = true;
}
return n_failed;
}
static int swap_points_list_off(MountPoint **head, bool *changed) {
MountPoint *m, *n;
int n_failed = 0;
assert(head);
assert(changed);
LIST_FOREACH_SAFE(mount_point, m, n, *head) {
log_info("Deactivating swap %s.", m->path);
if (swapoff(m->path) < 0) {
log_warning_errno(errno, "Could not deactivate swap %s: %m", m->path);
n_failed++;
continue;
}
*changed = true;
mount_point_free(head, m);
}
return n_failed;
}
static int loopback_points_list_detach(MountPoint **head, bool *changed, int umount_log_level) {
MountPoint *m, *n;
int n_failed = 0, r;
dev_t rootdev = 0;
assert(head);
assert(changed);
(void) get_block_device("/", &rootdev);
LIST_FOREACH_SAFE(mount_point, m, n, *head) {
if (major(rootdev) != 0 && rootdev == m->devnum) {
n_failed++;
continue;
}
log_info("Detaching loopback %s.", m->path);
r = delete_loopback(m->path);
if (r < 0) {
log_full_errno(umount_log_level, r, "Could not detach loopback %s: %m", m->path);
n_failed++;
continue;
}
if (r > 0)
*changed = true;
mount_point_free(head, m);
}
return n_failed;
}
static int dm_points_list_detach(MountPoint **head, bool *changed, int umount_log_level) {
MountPoint *m, *n;
int n_failed = 0, r;
dev_t rootdev = 0;
assert(head);
assert(changed);
(void) get_block_device("/", &rootdev);
LIST_FOREACH_SAFE(mount_point, m, n, *head) {
if (major(rootdev) != 0 && rootdev == m->devnum) {
n_failed ++;
continue;
}
log_info("Detaching DM %s (%u:%u).", m->path, major(m->devnum), minor(m->devnum));
r = delete_dm(m);
if (r < 0) {
log_full_errno(umount_log_level, r, "Could not detach DM %s: %m", m->path);
n_failed++;
continue;
2010-10-14 02:33:09 +02:00
}
*changed = true;
mount_point_free(head, m);
2010-10-14 02:33:09 +02:00
}
return n_failed;
2010-10-14 02:33:09 +02:00
}
static int md_points_list_detach(MountPoint **head, bool *changed, int umount_log_level) {
MountPoint *m, *n;
int n_failed = 0, r;
dev_t rootdev = 0;
assert(head);
assert(changed);
(void) get_block_device("/", &rootdev);
LIST_FOREACH_SAFE(mount_point, m, n, *head) {
if (major(rootdev) != 0 && rootdev == m->devnum) {
n_failed ++;
continue;
}
log_info("Stopping MD %s (%u:%u).", m->path, major(m->devnum), minor(m->devnum));
r = delete_md(m);
if (r < 0) {
log_full_errno(umount_log_level, r, "Could not stop MD %s: %m", m->path);
n_failed++;
continue;
}
*changed = true;
mount_point_free(head, m);
}
return n_failed;
}
static int umount_all_once(bool *changed, int umount_log_level) {
2018-03-14 11:32:13 +01:00
_cleanup_(mount_points_list_free) LIST_HEAD(MountPoint, mp_list_head);
int r;
assert(changed);
LIST_HEAD_INIT(mp_list_head);
r = mount_points_list_get(NULL, &mp_list_head);
if (r < 0)
2018-03-14 11:32:13 +01:00
return r;
core: systemd-shutdown: avoid confusingly redundant messages After previous output from systemd-shutdown indicated a bug, my attention was drawn to redundant output lines. Did they indicate an anomaly? It turns out to be an expected, harmless result of the current code. But we don't have much justification to run such redundant operations. Let's remove the confusing redundant message. We can stop trying to remount a directory read-only once its mount entry has successfully been changed to "ro". We can simply let the kernel keep track of this for us. I don't bother to try and avoid re-parsing the mountinfo. I appreciate snappy shutdowns, but this code is already intricate and buggy enough (see issue 7131). (Disclaimer: At least for the moment, you can't _rely_ on always seeing suspicious output from systemd-shutdown. By default, you can expect the kernel to truncate the log output of systemd-shutdown. Ick ick ick! Because /dev/kmsg is rate-limited by default. Normally it prints a message "X lines supressed", but we tend to shut down before the timer expires in this case). Before: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel... EXT4-fs (vda3): re-mounted. Opts: data=ordered systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered After: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered I also tested with `systemctl reboot --force`, plus a loopback mount to cause one of the umounts to fail initially. In this case another 2 lines of output are removed (out of a larger number of lines).
2017-10-19 16:02:12 +02:00
2018-03-14 11:32:13 +01:00
return mount_points_list_umount(&mp_list_head, changed, umount_log_level);
core: systemd-shutdown: avoid confusingly redundant messages After previous output from systemd-shutdown indicated a bug, my attention was drawn to redundant output lines. Did they indicate an anomaly? It turns out to be an expected, harmless result of the current code. But we don't have much justification to run such redundant operations. Let's remove the confusing redundant message. We can stop trying to remount a directory read-only once its mount entry has successfully been changed to "ro". We can simply let the kernel keep track of this for us. I don't bother to try and avoid re-parsing the mountinfo. I appreciate snappy shutdowns, but this code is already intricate and buggy enough (see issue 7131). (Disclaimer: At least for the moment, you can't _rely_ on always seeing suspicious output from systemd-shutdown. By default, you can expect the kernel to truncate the log output of systemd-shutdown. Ick ick ick! Because /dev/kmsg is rate-limited by default. Normally it prints a message "X lines supressed", but we tend to shut down before the timer expires in this case). Before: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel... EXT4-fs (vda3): re-mounted. Opts: data=ordered systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered After: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered I also tested with `systemctl reboot --force`, plus a loopback mount to cause one of the umounts to fail initially. In this case another 2 lines of output are removed (out of a larger number of lines).
2017-10-19 16:02:12 +02:00
}
int umount_all(bool *changed, int umount_log_level) {
core: systemd-shutdown: avoid confusingly redundant messages After previous output from systemd-shutdown indicated a bug, my attention was drawn to redundant output lines. Did they indicate an anomaly? It turns out to be an expected, harmless result of the current code. But we don't have much justification to run such redundant operations. Let's remove the confusing redundant message. We can stop trying to remount a directory read-only once its mount entry has successfully been changed to "ro". We can simply let the kernel keep track of this for us. I don't bother to try and avoid re-parsing the mountinfo. I appreciate snappy shutdowns, but this code is already intricate and buggy enough (see issue 7131). (Disclaimer: At least for the moment, you can't _rely_ on always seeing suspicious output from systemd-shutdown. By default, you can expect the kernel to truncate the log output of systemd-shutdown. Ick ick ick! Because /dev/kmsg is rate-limited by default. Normally it prints a message "X lines supressed", but we tend to shut down before the timer expires in this case). Before: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel... EXT4-fs (vda3): re-mounted. Opts: data=ordered systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered After: systemd-shutdown[1]: Remounting '/' read-only with options 'seclabel, ... EXT4-fs (vda3): re-mounted. Opts: data=ordered I also tested with `systemctl reboot --force`, plus a loopback mount to cause one of the umounts to fail initially. In this case another 2 lines of output are removed (out of a larger number of lines).
2017-10-19 16:02:12 +02:00
bool umount_changed;
int r;
assert(changed);
/* Retry umount, until nothing can be umounted anymore. Mounts are
* processed in order, newest first. The retries are needed when
* an old mount has been moved, to a path inside a newer mount. */
do {
umount_changed = false;
r = umount_all_once(&umount_changed, umount_log_level);
if (umount_changed)
*changed = true;
} while (umount_changed);
return r;
}
int swapoff_all(bool *changed) {
2018-03-14 11:32:13 +01:00
_cleanup_(mount_points_list_free) LIST_HEAD(MountPoint, swap_list_head);
int r;
assert(changed);
LIST_HEAD_INIT(swap_list_head);
r = swap_list_get(NULL, &swap_list_head);
if (r < 0)
2018-03-14 11:32:13 +01:00
return r;
2018-03-14 11:32:13 +01:00
return swap_points_list_off(&swap_list_head, changed);
}
int loopback_detach_all(bool *changed, int umount_log_level) {
2018-03-14 11:32:13 +01:00
_cleanup_(mount_points_list_free) LIST_HEAD(MountPoint, loopback_list_head);
int r;
assert(changed);
LIST_HEAD_INIT(loopback_list_head);
r = loopback_list_get(&loopback_list_head);
if (r < 0)
2018-03-14 11:32:13 +01:00
return r;
2018-03-14 11:32:13 +01:00
return loopback_points_list_detach(&loopback_list_head, changed, umount_log_level);
}
2010-10-14 02:33:09 +02:00
int dm_detach_all(bool *changed, int umount_log_level) {
2018-03-14 11:32:13 +01:00
_cleanup_(mount_points_list_free) LIST_HEAD(MountPoint, dm_list_head);
2010-10-14 02:33:09 +02:00
int r;
assert(changed);
LIST_HEAD_INIT(dm_list_head);
2010-10-14 02:33:09 +02:00
r = dm_list_get(&dm_list_head);
if (r < 0)
2018-03-14 11:32:13 +01:00
return r;
2010-10-14 02:33:09 +02:00
2018-03-14 11:32:13 +01:00
return dm_points_list_detach(&dm_list_head, changed, umount_log_level);
2010-10-14 02:33:09 +02:00
}
int md_detach_all(bool *changed, int umount_log_level) {
_cleanup_(mount_points_list_free) LIST_HEAD(MountPoint, md_list_head);
int r;
assert(changed);
LIST_HEAD_INIT(md_list_head);
r = md_list_get(&md_list_head);
if (r < 0)
return r;
return md_points_list_detach(&md_list_head, changed, umount_log_level);
}