picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cryptsetup: Do not warn If the key is /dev/*random 

Using /dev/urandom as a key is valid for swap, do not
warn if this devices are world readable.
This commit is contained in:
Cristian Rodríguez 2015-02-02 12:06:05 -03:00 committed by Martin Pitt
parent 5544ee8516
commit 05f73ad22b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cryptsetup/cryptsetup.c
View File

@ -624,8 +624,10 @@ int main(int argc, char *argv[]) {
/* Ideally we'd do this on the open fd, but since this is just a
* warning it's OK to do this in two steps. */
if (stat(key_file, &st) >= 0 && (st.st_mode & 0005))
log_warning("Key file %s is world-readable. This is not a good idea!", key_file);
if (stat(key_file, &st) >= 0 && (st.st_mode & 0005)) {
if(!STR_IN_SET(key_file, "/dev/urandom", "/dev/random", "/dev/hw_random"))
log_warning("Key file %s is world-readable. This is not a good idea!", key_file);
}
}
for (tries = 0; arg_tries == 0 || tries < arg_tries; tries++) {