From f26d09146088eefb577035ff59bd68114be08432 Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Wed, 16 Dec 2020 16:33:50 +0100 Subject: [PATCH 1/2] test: drop the trailing whitespace from the QEMU version check I suspect the original version of the regex was written on a system, which prints both the QEMU version and the QEMU package version in the --version output, like Fedora: $ /bin/qemu-system-x86_64 --version QEMU emulator version 4.2.1 (qemu-4.2.1-1.fc32) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers However, Arch Linux prints only the QEMU version: $ /bin/qemu-system-x86_64 --version QEMU emulator version 5.2.0 Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers This causes the awk regex to not match the version string, since there's no whitespace after it, causing the version check to fail (as well as the TEST-36-NUMAPOLICY) as well. Follow-up for 43b49470d1f2808555c07f64cd0a1529b7ddd559. --- test/test-functions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-functions b/test/test-functions index 39f2baea01..ce2c42b954 100644 --- a/test/test-functions +++ b/test/test-functions @@ -235,7 +235,7 @@ function qemu_min_version() { find_qemu_bin || return 2 # get version from binary - qemu_ver=$($QEMU_BIN --version | awk '/^QEMU emulator version ([0-9]*\.[0-9]*\.[0-9]*) / {print $4}') + qemu_ver=$($QEMU_BIN --version | awk '/^QEMU emulator version ([0-9]*\.[0-9]*\.[0-9]*)/ {print $4}') # Check version string format echo "$qemu_ver" | grep -q '^[0-9]*\.[0-9]*\.[0-9]*$' || return 2 From 26b127245aae42a870c9aca2a534bf9a9dbf6632 Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Wed, 16 Dec 2020 16:36:42 +0100 Subject: [PATCH 2/2] test: s/MUMA/NUMA/ --- test/TEST-36-NUMAPOLICY/test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/TEST-36-NUMAPOLICY/test.sh b/test/TEST-36-NUMAPOLICY/test.sh index a08ad6c14a..cec8b69920 100755 --- a/test/TEST-36-NUMAPOLICY/test.sh +++ b/test/TEST-36-NUMAPOLICY/test.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash set -e -TEST_DESCRIPTION="test MUMAPolicy= and NUMAMask= options" +TEST_DESCRIPTION="test NUMAPolicy= and NUMAMask= options" TEST_NO_NSPAWN=1 . $TEST_BASE_DIR/test-functions if qemu_min_version "5.2.0"; then