picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

dhcp-server: don't assign sendmsg() return value to "int"

Browse source 
The type is "ssize_t", not "int", let's be accurate about that, as these
types are different on some archs.

Given that we don't actually care about the return value reall, drop
the whole assignment, just check if negative.
This commit is contained in:
Lennart Poettering 2018-03-21 20:25:46 +01:00
parent 37cbc1d579
commit 0f01c1f918
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/libsystemd-network/sd-dhcp-server.c
View file

@ -313,7 +313,6 @@ static int dhcp_server_send_udp(sd_dhcp_server *server, be32_t destination,
};
struct cmsghdr *cmsg;
struct in_pktinfo *pktinfo;
int r;
assert(server);
assert(server->fd >= 0);
@ -337,8 +336,7 @@ static int dhcp_server_send_udp(sd_dhcp_server *server, be32_t destination,
pktinfo->ipi_ifindex = server->ifindex;
pktinfo->ipi_spec_dst.s_addr = server->address;
r = sendmsg(server->fd, &msg, 0);
if (r < 0)
if (sendmsg(server->fd, &msg, 0) < 0)
return -errno;
return 0;