picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

boot/shim: fix char ** vs char * mismatch

Browse source 
This code cannot have ever worked ;(

Found by coverity, obvious when the type is not obfuscated to void*.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2017-11-27 12:36:21 +00:00
parent bceda88b52
commit 10a6e01eaa
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/boot/efi/shim.c
View file

@ -162,7 +162,7 @@ static EFIAPI EFI_STATUS security_policy_authentication (const EFI_SECURITY_PROT
EFI_DEVICE_PATH *dev_path;
EFI_HANDLE h;
EFI_FILE *root;
VOID *file_buffer = NULL;
CHAR8 *file_buffer = NULL;
UINTN file_size;
CHAR16 *dev_path_str;
@ -182,7 +182,7 @@ static EFIAPI EFI_STATUS security_policy_authentication (const EFI_SECURITY_PROT
dev_path_str = DevicePathToStr(dev_path);
FreePool(dev_path);
file_size = file_read(root, dev_path_str, 0, 0, file_buffer);
file_size = file_read(root, dev_path_str, 0, 0, &file_buffer);
FreePool(dev_path_str);
uefi_call_wrapper(root->Close, 1, root);