From 152c475f95c7b9b20d293dafea06108b0c488866 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 23 Jan 2018 19:37:59 +0100 Subject: [PATCH] namepace: fix error handling when clone_device_node() returns 0 Before this patch, we'd treat clone_device_node() returning 0 (as opposed to 1) as error, but then propagate this non-error result in confusion. This makes sure that if we ptmx isn't around we propagate that as -ENXIO. This is a follow-up for 98b1d2b8d9ea27087a5980b4b902b6a6ab716e03 --- src/core/namespace.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/namespace.c b/src/core/namespace.c index 565b954482..70089f212a 100644 --- a/src/core/namespace.c +++ b/src/core/namespace.c @@ -578,8 +578,12 @@ static int mount_private_dev(MountEntry *m) { } } else { r = clone_device_node("/dev/ptmx", temporary_mount); - if (r != 1) + if (r < 0) goto fail; + if (r == 0) { + r = -ENXIO; + goto fail; + } } devshm = strjoina(temporary_mount, "/dev/shm");