diff --git a/TODO b/TODO index 4404a53abd..81f3023281 100644 --- a/TODO +++ b/TODO @@ -71,8 +71,6 @@ Features: * Add a new verb "systemctl top" -* order OnCalendar timer units after timer-sync.target if DefaultDependencies=no so that we don't trigger them prematurely - * refuse mounting on symlinks * logind: allow users to kill or lock their own sessions diff --git a/man/systemd.timer.xml b/man/systemd.timer.xml index d82b9bdc97..9fcf5ccb97 100644 --- a/man/systemd.timer.xml +++ b/man/systemd.timer.xml @@ -78,15 +78,20 @@ Unit= (see below). Unless DefaultDependencies= - is set to , timer units will + is set to , all timer units will implicitly have dependencies of type Conflicts= and Before= on - shutdown.target. These ensure - that timer units are stopped cleanly prior to system - shutdown. Only timer units involved with early boot or - late system shutdown should disable this - option. + shutdown.target to ensure that + they are stopped cleanly prior to system shutdown. + Timer units with at least one + OnCalendar= directive will have an + additional After= dependency on + timer-sync.target to avoid + being started before the system clock has been + correctly set. Only timer units involved with early + boot or late system shutdown should disable the + DefaultDependencies= option. diff --git a/src/core/timer.c b/src/core/timer.c index a5a33a6e6f..dc0f289c7a 100644 --- a/src/core/timer.c +++ b/src/core/timer.c @@ -95,6 +95,7 @@ static int timer_verify(Timer *t) { static int timer_add_default_dependencies(Timer *t) { int r; + TimerValue *v; assert(t); @@ -106,6 +107,15 @@ static int timer_add_default_dependencies(Timer *t) { r = unit_add_two_dependencies_by_name(UNIT(t), UNIT_AFTER, UNIT_REQUIRES, SPECIAL_SYSINIT_TARGET, NULL, true); if (r < 0) return r; + + LIST_FOREACH(value, v, t->values) { + if (v->base == TIMER_CALENDAR) { + r = unit_add_dependency_by_name(UNIT(t), UNIT_AFTER, SPECIAL_TIME_SYNC_TARGET, NULL, true); + if (r < 0) + return r; + break; + } + } } return unit_add_two_dependencies_by_name(UNIT(t), UNIT_BEFORE, UNIT_CONFLICTS, SPECIAL_SHUTDOWN_TARGET, NULL, true); diff --git a/src/shared/special.h b/src/shared/special.h index 2fe5db5558..b045047d36 100644 --- a/src/shared/special.h +++ b/src/shared/special.h @@ -57,13 +57,13 @@ #define SPECIAL_REMOTE_FS_PRE_TARGET "remote-fs-pre.target" #define SPECIAL_SWAP_TARGET "swap.target" #define SPECIAL_NETWORK_ONLINE_TARGET "network-online.target" +#define SPECIAL_TIME_SYNC_TARGET "time-sync.target" /* LSB's $time */ #define SPECIAL_BASIC_TARGET "basic.target" /* LSB compatibility */ #define SPECIAL_NETWORK_TARGET "network.target" /* LSB's $network */ #define SPECIAL_NSS_LOOKUP_TARGET "nss-lookup.target" /* LSB's $named */ #define SPECIAL_RPCBIND_TARGET "rpcbind.target" /* LSB's $portmap */ -#define SPECIAL_TIME_SYNC_TARGET "time-sync.target" /* LSB's $time */ /* * Rules regarding adding further high level targets like the above: