diff --git a/src/basic/rm-rf.c b/src/basic/rm-rf.c index 01ff6bb331..ab331cd677 100644 --- a/src/basic/rm-rf.c +++ b/src/basic/rm-rf.c @@ -45,7 +45,7 @@ static int unlinkat_harder( return -errno; if (!S_ISDIR(st.st_mode)) return -ENOTDIR; - if ((st.st_mode & 0700) == 0700) /* Already set? */ + if (FLAGS_SET(st.st_mode, 0700)) /* Already set? */ return -EACCES; /* original error */ if (st.st_uid != geteuid()) /* this only works if the UID matches ours */ return -EACCES; diff --git a/src/core/unit.c b/src/core/unit.c index c3d7d24ecc..43373f35d4 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -5502,7 +5502,7 @@ void unit_remove_dependencies(Unit *u, UnitDependencyMask mask) { done = true; HASHMAP_FOREACH_KEY(di.data, other, u->dependencies[d]) { - if ((di.origin_mask & ~mask) == di.origin_mask) + if (FLAGS_SET(~mask, di.origin_mask)) continue; di.origin_mask &= ~mask; unit_update_dependency_mask(u, d, other, di); @@ -5516,7 +5516,7 @@ void unit_remove_dependencies(Unit *u, UnitDependencyMask mask) { UnitDependencyInfo dj; dj.data = hashmap_get(other->dependencies[q], u); - if ((dj.destination_mask & ~mask) == dj.destination_mask) + if (FLAGS_SET(~mask, dj.destination_mask)) continue; dj.destination_mask &= ~mask; diff --git a/src/libsystemd-network/sd-dhcp-lease.c b/src/libsystemd-network/sd-dhcp-lease.c index 0bc5fa3210..83e1b90291 100644 --- a/src/libsystemd-network/sd-dhcp-lease.c +++ b/src/libsystemd-network/sd-dhcp-lease.c @@ -779,7 +779,7 @@ int dhcp_lease_parse_search_domains(const uint8_t *option, size_t len, char ***d return r; n += r; - } else if ((c & 0xc0) == 0xc0) { + } else if (FLAGS_SET(c, 0xc0)) { /* Pointer */ uint8_t d; diff --git a/src/libsystemd-network/sd-dhcp6-client.c b/src/libsystemd-network/sd-dhcp6-client.c index 6bbc23f131..38025b63d9 100644 --- a/src/libsystemd-network/sd-dhcp6-client.c +++ b/src/libsystemd-network/sd-dhcp6-client.c @@ -270,7 +270,7 @@ static int dhcp6_client_set_duid_internal( assert_return(duid_len == 0 || duid != NULL, -EINVAL); assert_return(IN_SET(client->state, DHCP6_STATE_STOPPED), -EBUSY); - if (duid != NULL) { + if (duid) { r = dhcp_validate_duid_len(duid_type, duid_len, true); if (r < 0) { r = dhcp_validate_duid_len(duid_type, duid_len, false); diff --git a/src/shared/calendarspec.c b/src/shared/calendarspec.c index db6a103c42..bcc51f973c 100644 --- a/src/shared/calendarspec.c +++ b/src/shared/calendarspec.c @@ -363,7 +363,7 @@ int calendar_spec_to_string(const CalendarSpec *c, char **p) { if (c->utc) fputs(" UTC", f); - else if (c->timezone != NULL) { + else if (c->timezone) { fputc(' ', f); fputs(c->timezone, f); } else if (IN_SET(c->dst, 0, 1)) { diff --git a/src/shared/chown-recursive.c b/src/shared/chown-recursive.c index 636c0e2a7f..cb75d9a11b 100644 --- a/src/shared/chown-recursive.c +++ b/src/shared/chown-recursive.c @@ -124,7 +124,7 @@ int path_chown_recursive( if (fd < 0) return -errno; - if (!uid_is_valid(uid) && !gid_is_valid(gid) && (mask & 07777) == 07777) + if (!uid_is_valid(uid) && !gid_is_valid(gid) && FLAGS_SET(mask, 07777)) return 0; /* nothing to do */ if (fstat(fd, &st) < 0) @@ -160,7 +160,7 @@ int fd_chown_recursive( if (!S_ISDIR(st.st_mode)) return -ENOTDIR; - if (!uid_is_valid(uid) && !gid_is_valid(gid) && (mask & 07777) == 07777) + if (!uid_is_valid(uid) && !gid_is_valid(gid) && FLAGS_SET(mask, 07777)) return 0; /* nothing to do */ /* Shortcut, as above */ diff --git a/src/test/test-namespace.c b/src/test/test-namespace.c index 3972207329..7571e609a2 100644 --- a/src/test/test-namespace.c +++ b/src/test/test-namespace.c @@ -46,7 +46,7 @@ static void test_tmpdir(const char *id, const char *A, const char *B) { c = strjoina(a, "/tmp"); assert_se(stat(c, &x) >= 0); assert_se(S_ISDIR(x.st_mode)); - assert_se((x.st_mode & 01777) == 01777); + assert_se(FLAGS_SET(x.st_mode, 01777)); assert_se(rmdir(c) >= 0); assert_se(rmdir(a) >= 0); } @@ -57,7 +57,7 @@ static void test_tmpdir(const char *id, const char *A, const char *B) { d = strjoina(b, "/tmp"); assert_se(stat(d, &y) >= 0); assert_se(S_ISDIR(y.st_mode)); - assert_se((y.st_mode & 01777) == 01777); + assert_se(FLAGS_SET(y.st_mode, 01777)); assert_se(rmdir(d) >= 0); assert_se(rmdir(b) >= 0); } diff --git a/src/udev/scsi_id/scsi_id.c b/src/udev/scsi_id/scsi_id.c index bb08da28b5..9c33a560a8 100644 --- a/src/udev/scsi_id/scsi_id.c +++ b/src/udev/scsi_id/scsi_id.c @@ -236,7 +236,7 @@ static int get_file_options(const char *vendor, const char *model, retval = -1; break; } - if (vendor == NULL) { + if (!vendor) { if (!vendor_in) break; } else if (vendor_in &&