diff --git a/src/network/networkd.c b/src/network/networkd.c index 4fa5533c60..fcecafe083 100644 --- a/src/network/networkd.c +++ b/src/network/networkd.c @@ -4,13 +4,16 @@ #include "sd-event.h" #include "capability-util.h" +#include "daemon-util.h" +#include "main-func.h" #include "mkdir.h" #include "networkd-conf.h" #include "networkd-manager.h" #include "signal-util.h" #include "user-util.h" -int main(int argc, char *argv[]) { +static int run(int argc, char *argv[]) { + _cleanup_(notify_on_cleanup) const char *notify_message = NULL; _cleanup_(manager_freep) Manager *m = NULL; const char *user = "systemd-network"; uid_t uid; @@ -21,17 +24,12 @@ int main(int argc, char *argv[]) { umask(0022); - if (argc != 1) { - log_error("This program takes no arguments."); - r = -EINVAL; - goto out; - } + if (argc != 1) + return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "This program takes no arguments."); r = get_user_creds(&user, &uid, &gid, NULL, NULL, 0); - if (r < 0) { - log_error_errno(r, "Cannot resolve user name %s: %m", user); - goto out; - } + if (r < 0) + return log_error_errno(r, "Cannot resolve user name %s: %m", user); /* Create runtime directory. This is not necessary when networkd is * started with "RuntimeDirectory=systemd/netif", or after @@ -49,7 +47,7 @@ int main(int argc, char *argv[]) { (1ULL << CAP_NET_BROADCAST) | (1ULL << CAP_NET_RAW)); if (r < 0) - goto out; + return log_error_errno(r, "Failed to drop privileges: %m"); } /* Always create the directories people can create inotify watches in. @@ -70,72 +68,50 @@ int main(int argc, char *argv[]) { assert_se(sigprocmask_many(SIG_BLOCK, NULL, SIGTERM, SIGINT, -1) >= 0); r = manager_new(&m); - if (r < 0) { - log_error_errno(r, "Could not create manager: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not create manager: %m"); r = manager_connect_bus(m); - if (r < 0) { - log_error_errno(r, "Could not connect to bus: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not connect to bus: %m"); r = manager_parse_config_file(m); if (r < 0) log_warning_errno(r, "Failed to parse configuration file: %m"); r = manager_load_config(m); - if (r < 0) { - log_error_errno(r, "Could not load configuration files: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not load configuration files: %m"); r = manager_rtnl_enumerate_links(m); - if (r < 0) { - log_error_errno(r, "Could not enumerate links: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not enumerate links: %m"); r = manager_rtnl_enumerate_addresses(m); - if (r < 0) { - log_error_errno(r, "Could not enumerate addresses: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not enumerate addresses: %m"); r = manager_rtnl_enumerate_routes(m); - if (r < 0) { - log_error_errno(r, "Could not enumerate routes: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not enumerate routes: %m"); r = manager_rtnl_enumerate_rules(m); - if (r < 0) { - log_error_errno(r, "Could not enumerate rules: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not enumerate rules: %m"); r = manager_start(m); - if (r < 0) { - log_error_errno(r, "Could not start manager: %m"); - goto out; - } + if (r < 0) + return log_error_errno(r, "Could not start manager: %m"); log_info("Enumeration completed"); - sd_notify(false, - "READY=1\n" - "STATUS=Processing requests..."); + notify_message = notify_start(NOTIFY_READY, NOTIFY_STOPPING); r = sd_event_loop(m->event); - if (r < 0) { - log_error_errno(r, "Event loop failed: %m"); - goto out; - } -out: - sd_notify(false, - "STOPPING=1\n" - "STATUS=Shutting down..."); + if (r < 0) + return log_error_errno(r, "Event loop failed: %m"); - return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS; + return 0; } + +DEFINE_MAIN_FUNCTION(run);