picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

resolved: always split up questions into per-RR transactions

Browse source 
We do so for Unicast DNS and LLMNR anyway, let's also do this for mDNS,
and simplify things.
This commit is contained in:
Lennart Poettering 2015-08-21 22:59:38 +02:00
parent f52e61da04
commit 26b1c471cd
1 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/resolve/resolved-dns-query.c
View file

@ -143,6 +143,7 @@ static int dns_query_add_transaction(DnsQuery *q, DnsScope *s, DnsResourceKey *k
assert(q);
assert(s);
assert(key);
r = set_ensure_allocated(&q->transactions, NULL);
if (r < 0)
@ -177,27 +178,18 @@ gc:
}
static int dns_query_add_transaction_split(DnsQuery *q, DnsScope *s) {
unsigned i;
int r;
assert(q);
assert(s);
if (s->protocol == DNS_PROTOCOL_MDNS) {
r = dns_query_add_transaction(q, s, NULL);
/* Create one transaction per question key */
for (i = 0; i < q->question->n_keys; i++) {
r = dns_query_add_transaction(q, s, q->question->keys[i]);
if (r < 0)
return r;
} else {
unsigned i;
/* On DNS and LLMNR we can only send a single
* question per datagram, hence issue multiple
* transactions. */
for (i = 0; i < q->question->n_keys; i++) {
r = dns_query_add_transaction(q, s, q->question->keys[i]);
if (r < 0)
return r;
}
}
return 0;