From 2e4beb875bcb24e7d7d4339cc202b0b3f2953f71 Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Mon, 27 May 2019 09:27:54 +0200 Subject: [PATCH] cryptsetup: Do not fallback to PLAIN mapping if LUKS data device set fails. If crypt_load() for LUKS succeeds, we know that it is a LUKS device. Failure of data device setting should fail in this case; remapping as a PLAIN device late could mean data corruption. (If a user wants to map PLAIN device over a device with LUKS header, it should be said explicitly with "plain" argument type.) Also, if there is no explicit PLAIN type requested and crypt device is already initialized (crypt_data_type() is set), do not run the initialization again. --- src/cryptsetup/cryptsetup.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index 864d6ff472..bf523fe50d 100644 --- a/src/cryptsetup/cryptsetup.c +++ b/src/cryptsetup/cryptsetup.c @@ -502,11 +502,14 @@ static int attach_luks_or_plain(struct crypt_device *cd, if (r < 0) return log_error_errno(r, "Failed to load LUKS superblock on device %s: %m", crypt_get_device_name(cd)); - if (data_device) + if (data_device) { r = crypt_set_data_device(cd, data_device); + if (r < 0) + return log_error_errno(r, "Failed to set LUKS data device %s: %m", data_device); + } } - if ((!arg_type && r < 0) || streq_ptr(arg_type, CRYPT_PLAIN)) { + if ((!arg_type && !crypt_get_type(cd)) || streq_ptr(arg_type, CRYPT_PLAIN)) { struct crypt_params_plain params = { .offset = arg_offset, .skip = arg_skip, @@ -547,12 +550,12 @@ static int attach_luks_or_plain(struct crypt_device *cd, /* In contrast to what the name crypt_setup() might suggest this doesn't actually format * anything, it just configures encryption parameters when used for plain mode. */ r = crypt_format(cd, CRYPT_PLAIN, cipher, cipher_mode, NULL, NULL, arg_keyfile_size, ¶ms); + if (r < 0) + return log_error_errno(r, "Loading of cryptographic parameters failed: %m"); /* hash == NULL implies the user passed "plain" */ pass_volume_key = (params.hash == NULL); } - if (r < 0) - return log_error_errno(r, "Loading of cryptographic parameters failed: %m"); log_info("Set cipher %s, mode %s, key size %i bits for device %s.", crypt_get_cipher(cd),