picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

networkd: unbreak routing_policy_rule_compare_func()

Browse source 
!r is the same r == 0, so this was short-circuiting the comparison when
streq(a->iff, b->iff) or streq(a->off, b->off). Before the parent commit which
moved those comparisons to the end, this was short-circuiting quite a bit
of the comparison function.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2019-09-17 19:27:58 +02:00
parent a811fb8b37
commit 314ed4f994
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/network/networkd-routing-policy-rule.c
View file

@ -199,11 +199,11 @@ static int routing_policy_rule_compare_func(const RoutingPolicyRule *a, const Ro
return r;
r = strcmp_ptr(a->iif, b->iif);
if (!r)
if (r != 0)
return r;
r = strcmp_ptr(a->oif, b->oif);
if (!r)
if (r != 0)
return r;
return 0;