networkd-tests.py: add helpers to common subprocess call patterns

Browse Source

For normal shell calls, python syntax is quite verbose. We don't need to punish
ourselves like that. In some places we would fork a shell to do argument splitting
for us. We know that our arguments can be safely split on whitespace, so let's do
that ourselves in all cases, without forking a shell.

We also expect command output to be valid text, so let's always set
universal_newlines=True.

This makes things shorter and easier to read. Development is also easier because
it's possible to paste many of the commands directly to/from a shell.

...

This commit is contained in:

Zbigniew Jędrzejewski-Szmek 2019-06-05 11:43:28 +02:00

parent 632037cf4a

commit 371810d18a

1 changed files with 235 additions and 224 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

459

test/test-network/systemd-networkd-tests.py

View File

File diff suppressed because it is too large Load Diff