From 3f181262f4aa746177ea311827c268652bdb1c33 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 14 Aug 2020 11:07:18 +0200 Subject: [PATCH] namespace: fix minor memory leak --- src/core/namespace.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/core/namespace.c b/src/core/namespace.c index f2288df79b..858ccc4118 100644 --- a/src/core/namespace.c +++ b/src/core/namespace.c @@ -1967,11 +1967,11 @@ static int make_tmp_prefix(const char *prefix) { static int make_tmp_subdir(const char *parent, char **ret) { _cleanup_free_ char *y = NULL; - RUN_WITH_UMASK(0000) { - y = strjoin(parent, "/tmp"); - if (!y) - return -ENOMEM; + y = path_join(parent, "/tmp"); + if (!y) + return -ENOMEM; + RUN_WITH_UMASK(0000) { if (mkdir(y, 0777 | S_ISVTX) < 0) return -errno; } @@ -2027,9 +2027,9 @@ static int setup_one_tmp_dir(const char *id, const char *prefix, char **path, ch if (r < 0) return r; - x = strdup(RUN_SYSTEMD_EMPTY); - if (!x) - return -ENOMEM; + r = free_and_strdup(&x, RUN_SYSTEMD_EMPTY); + if (r < 0) + return r; } *path = TAKE_PTR(x);