picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

path: don't use IN_ATTRIB on parent dirs when watching a file, since those cannot be removed without emptying the dir first anyway and we need IN_ATTRIB only to detect the link count dropping to 0

This commit is contained in:
Lennart Poettering 2011-03-04 00:22:00 +01:00
parent 430c18ed7f
commit 3fc546f93d
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
TODO
View File

@ -11,9 +11,6 @@ F15:
* load EnvironmentFile= when starting services, not when reloading configuration
https://bugzilla.redhat.com/show_bug.cgi?id=661282
* drop IN_ATTRIB from inotify watches for .path units where possible to avoid
lots of wakeups due to /dev changing when we watch a subdir of /dev.
* NFS, networkmanager ordering issue
* add fstab fields to add wait timeouts, change Wants to Requires by local-fs.target

4
src/path.c
View File

@ -223,9 +223,9 @@ static int path_watch_one(Path *p, PathSpec *s) {
/* Trim the path at the last slash. Keep the slash if it's the root dir. */
slash[slash == k] = 0;
flags = IN_DELETE_SELF|IN_MOVE_SELF|IN_ATTRIB;
flags = IN_MOVE_SELF;
if (!exists)
flags |= IN_CREATE | IN_MOVED_TO;
flags |= IN_DELETE_SELF | IN_ATTRIB | IN_CREATE | IN_MOVED_TO;
if (inotify_add_watch(s->inotify_fd, k, flags) >= 0)
exists = true;