From 4472fa6d2c324be002ea04dd10070f7bbac261cf Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 16 Nov 2018 18:08:29 +0100 Subject: [PATCH] conf-parse: use strjoina() where appropriate --- src/shared/conf-parser.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/shared/conf-parser.c b/src/shared/conf-parser.c index b417ac2d6d..8110b2cb16 100644 --- a/src/shared/conf-parser.c +++ b/src/shared/conf-parser.c @@ -82,19 +82,13 @@ int config_item_perf_lookup( assert(ltype); assert(data); - if (!section) - p = lookup(lvalue, strlen(lvalue)); - else { - char *key; - - key = strjoin(section, ".", lvalue); - if (!key) - return -ENOMEM; + if (section) { + const char *key; + key = strjoina(section, ".", lvalue); p = lookup(key, strlen(key)); - free(key); - } - + } else + p = lookup(lvalue, strlen(lvalue)); if (!p) return 0; @@ -132,7 +126,6 @@ static int next_assignment( r = lookup(table, section, lvalue, &func, <ype, &data, userdata); if (r < 0) return r; - if (r > 0) { if (func) return func(unit, filename, line, section, section_line,