diff --git a/src/basic/util.c b/src/basic/util.c index 2a39ff2b53..b1e6f5002e 100644 --- a/src/basic/util.c +++ b/src/basic/util.c @@ -61,6 +61,7 @@ #include "umask-util.h" #include "user-util.h" #include "util.h" +#include "virt.h" int saved_argc = 0; char **saved_argv = NULL; @@ -615,3 +616,9 @@ int str_verscmp(const char *s1, const char *s2) { return strcmp(os1, os2); } + +/* Turn off core dumps but only if we're running outside of a container. */ +void disable_core_dumps(void) { + if (detect_container() <= 0) + (void) write_string_file("/proc/sys/kernel/core_pattern", "|/bin/false", 0); +} diff --git a/src/basic/util.h b/src/basic/util.h index 20181ab917..c10cfea952 100644 --- a/src/basic/util.h +++ b/src/basic/util.h @@ -191,3 +191,5 @@ int update_reboot_parameter_and_warn(const char *param); int version(void); int str_verscmp(const char *s1, const char *s2); + +void disable_core_dumps(void); diff --git a/src/core/main.c b/src/core/main.c index 63533dbe10..ef7d7f58dc 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -91,6 +91,7 @@ #include "terminal-util.h" #include "umask-util.h" #include "user-util.h" +#include "util.h" #include "virt.h" #include "watchdog.h" @@ -1603,7 +1604,7 @@ static void initialize_coredump(bool skip_setup) { /* But at the same time, turn off the core_pattern logic by default, so that no coredumps are stored * until the systemd-coredump tool is enabled via sysctl. */ if (!skip_setup) - (void) write_string_file("/proc/sys/kernel/core_pattern", "|/bin/false", 0); + disable_core_dumps(); } static void do_reexecute( diff --git a/src/core/shutdown.c b/src/core/shutdown.c index ffab4de101..b1f581b548 100644 --- a/src/core/shutdown.c +++ b/src/core/shutdown.c @@ -323,6 +323,9 @@ int main(int argc, char *argv[]) { if (!in_container) sync_with_progress(); + /* Prevent coredumps */ + disable_core_dumps(); + log_info("Sending SIGTERM to remaining processes..."); broadcast_signal(SIGTERM, true, true); diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c index e6063cc980..f83a951df7 100644 --- a/src/coredump/coredump.c +++ b/src/coredump/coredump.c @@ -1126,7 +1126,7 @@ static int gather_pid_metadata( /* If this is PID 1 disable coredump collection, we'll unlikely be able to process it later on. */ if (is_pid1_crash((const char**) context)) { log_notice("Due to PID 1 having crashed coredump collection will now be turned off."); - (void) write_string_file("/proc/sys/kernel/core_pattern", "|/bin/false", 0); + disable_core_dumps(); } set_iovec_field(iovec, n_iovec, "COREDUMP_UNIT=", context[CONTEXT_UNIT]);