picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

capability: fix loops for cap_last_cap()

Browse source 
cap_last_cap() returns the last valid cap (instead of the number of
valid caps). to iterate through all known caps we hence need to use a <=
check, and not a < check like for all other cases. We got this right
usually, but in three cases we did not.
This commit is contained in:
Lennart Poettering 2019-06-20 14:44:47 +02:00
parent 9af2820694
commit 4a33a02e99
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/basic/cap-list.c
View file

@ -62,7 +62,7 @@ int capability_set_to_string_alloc(uint64_t set, char **s) {
assert(s);
for (i = 0; i < cap_last_cap(); i++)
for (i = 0; i <= cap_last_cap(); i++)
if (set & (UINT64_C(1) << i)) {
const char *p;
size_t add;

4
src/basic/capability-util.c
View file

@ -90,7 +90,7 @@ int capability_update_inherited_set(cap_t caps, uint64_t set) {
/* Add capabilities in the set to the inherited caps. Do not apply
* them yet. */
for (i = 0; i < cap_last_cap(); i++) {
for (i = 0; i <= cap_last_cap(); i++) {
if (set & (UINT64_C(1) << i)) {
cap_value_t v;
@ -126,7 +126,7 @@ int capability_ambient_set_apply(uint64_t set, bool also_inherit) {
return -errno;
}
for (i = 0; i < cap_last_cap(); i++) {
for (i = 0; i <= cap_last_cap(); i++) {
if (set & (UINT64_C(1) << i)) {