picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

manager: log log level changes uniformly 

Output the same message when a request to change the log level is
received over dbus and through a signal. From the user point of view
those two operations are very similar and it's easy to think that the
dbus operation didn't work when the expected message is not emitted.

Also "downgrade" the message level to info, since this is a normal
user initiated action.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2015-12-09 21:29:38 -05:00
parent 76b6f3f68f
commit 4cee3a78bb
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/dbus-manager.c
View File

@ -229,7 +229,10 @@ static int property_set_log_level(
if (r < 0)
return r;
return log_set_max_level_from_string(t);
r = log_set_max_level_from_string(t);
if (r == 0)
log_info("Setting log level to %s.", t);
return r;
}
static int property_get_n_names(

4
src/core/manager.c
View File

@ -1894,12 +1894,12 @@ static int manager_dispatch_signal_fd(sd_event_source *source, int fd, uint32_t
case 22:
log_set_max_level(LOG_DEBUG);
log_notice("Setting log level to debug.");
log_info("Setting log level to debug.");
break;
case 23:
log_set_max_level(LOG_INFO);
log_notice("Setting log level to info.");
log_info("Setting log level to info.");
break;
case 24: