picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

systemctl: we can make this faster and shorten it a bit with strv_extend()

Browse source 
Now that strv_extend() is not so slow anymore, we can make use of it, to
shorten our code a bit.
This commit is contained in:
Lennart Poettering 2013-01-18 00:51:46 +01:00
parent 82dde599ed
commit 540e7dbe9e
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/systemctl/systemctl.c
View file

@ -760,7 +760,6 @@ static int list_dependencies_get_dependencies(DBusConnection *bus, const char *n
int r = 0;
char **ret = NULL;
char **c;
assert(bus);
assert(name);
@ -834,13 +833,13 @@ static int list_dependencies_get_dependencies(DBusConnection *bus, const char *n
assert(dbus_message_iter_get_arg_type(&sub4) == DBUS_TYPE_STRING);
dbus_message_iter_get_basic(&sub4, &s);
c = strv_append(ret, s);
if (c == NULL) {
r = log_oom();
r = strv_extend(&ret, s);
if (r < 0) {
log_oom();
goto finish;
}
strv_free(ret);
ret = c;
dbus_message_iter_next(&sub4);
}
}