From 662d74daf7c9489f08f2a05518567278a8a4945a Mon Sep 17 00:00:00 2001
From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 26 Feb 2020 22:26:23 +0900
Subject: [PATCH] userdb: make userdb_all() always set iterator when it returns
 >= 0

Fixes #14868.
---
 src/shared/userdb.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/shared/userdb.c b/src/shared/userdb.c
index 215e17db9b..1f05cda26a 100644
--- a/src/shared/userdb.c
+++ b/src/shared/userdb.c
@@ -700,12 +700,8 @@ int userdb_all(UserDBFlags flags, UserDBIterator **ret) {
                 setpwent();
                 iterator->nss_iterating = true;
                 goto finish;
-        }
-
-        if (!FLAGS_SET(flags, USERDB_DONT_SYNTHESIZE))
-                goto finish;
-
-        return r;
+        } else if (r < 0)
+                return r;
 
 finish:
         *ret = TAKE_PTR(iterator);