picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

udev: path_id - clarify comment about the kernel ATA naming problem

This commit is contained in:
Kay Sievers 2013-01-17 00:00:02 +01:00
parent 5d4caf5654
commit 59d86149b0
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/udev/udev-builtin-path_id.c
View File

@ -356,7 +356,7 @@ static struct udev_device *handle_scsi(struct udev_device *parent, char **path)
goto out;
}
/* lousy scsi sysfs does not have a "subsystem" for the transport */
/* scsi sysfs does not have a "subsystem" for the transport */
name = udev_device_get_syspath(parent);
if (strstr(name, "/rport-") != NULL) {
@ -375,12 +375,15 @@ static struct udev_device *handle_scsi(struct udev_device *parent, char **path)
}
/*
* We do not support the ATA transport class, it creates duplicated link
* names as the fake SCSI host adapters are all separated, they are all
* re-based as host == 0. ATA should just stop faking two duplicated
* hierarchies for a single topology and leave the SCSI stuff alone;
* until that happens, there are no by-path/ links for ATA devices behind
* an ATA transport class.
* We do not support the ATA transport class, it uses global counters
* to name the ata devices which numbers spread across multiple
* controllers.
*
* The real link numbers are not exported. Also, possible chains of ports
* behind port multipliers cannot be composed that way.
*
* Until all that is solved at the kernel level, there are no by-path/
* links for ATA devices.
*/
if (strstr(name, "/ata") != NULL) {
parent = NULL;