picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test-socket-netlink: print the proper expected string 

We would use the return value from the tested function to decide
what to print as "expected", which is confusing when something is wrong
with the tested function.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2020-09-03 12:58:30 +02:00
parent 38c30b35f3
commit 610618ff61
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/test-socket-netlink.c
View File

@ -12,11 +12,19 @@ static void test_socket_address_parse_one(const char *in, int ret, int family, c
int r;
r = socket_address_parse(&a, in);
if (r >= 0)
assert_se(socket_address_print(&a, &out) >= 0);
if (r >= 0) {
r = socket_address_print(&a, &out);
if (r < 0)
log_error_errno(r, "Printing failed for \"%s\": %m", in);
assert(r >= 0);
}
log_info("\"%s\" → %s → \"%s\" (expect \"%s\")", in,
r >= 0 ? "✓" : "✗", empty_to_dash(out), r >= 0 ? expected ?: in : "-");
log_info("\"%s\" → %s %d → \"%s\" (expect %d / \"%s\")",
in,
r >= 0 ? "✓" : "✗", r,
empty_to_dash(out),
ret,
ret >= 0 ? expected ?: in : "-");
assert_se(r == ret);
if (r >= 0) {
assert_se(a.sockaddr.sa.sa_family == family);