picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

udev: rules - close empty file 

If the file is found to be empty, we exit early without closing the file first.

Found by coverity. Fixes CID #1237759.
This commit is contained in:
Tom Gundersen 2014-09-17 19:53:01 +02:00
parent 6f42877282
commit 6c8aaf0c1b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/udev/udev-rules.c
View File

@ -1575,7 +1575,7 @@ invalid:
}
static int parse_file(struct udev_rules *rules, const char *filename) {
FILE *f;
_cleanup_fclose_ FILE *f = NULL;
unsigned int first_token;
unsigned int filename_off;
char line[UTIL_LINE_SIZE];
@ -1633,7 +1633,6 @@ static int parse_file(struct udev_rules *rules, const char *filename) {
}
add_rule(rules, key, filename, filename_off, line_nr);
}
fclose(f);
/* link GOTOs to LABEL rules in this file to be able to fast-forward */
for (i = first_token+1; i < rules->token_cur; i++) {