picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

base-file-system: always generate error messages locally 

Functions either should generate error messages for everything they do
themselves, or for nothing and let the caller do it. But they certainly
shouldn't generate errors for some messages but not for others. Since
the function in this case is one that generates messages on its own, it
really should do that for everything, not just for some things, hence.
This commit is contained in:
Lennart Poettering 2014-09-03 19:00:21 +02:00
parent 64e84dbb14
commit 6dc2852c64
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/shared/base-filesystem.c
View File

@ -58,16 +58,17 @@ int base_filesystem_create(const char *root) {
int r;
fd = open(root, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC|O_NOFOLLOW);
if (fd < 0)
if (fd < 0) {
log_error("Failed to open root file system: %m");
return -errno;
}
for (i = 0; i < ELEMENTSOF(table); i ++) {
if (faccessat(fd, table[i].dir, F_OK, AT_SYMLINK_NOFOLLOW) >= 0)
continue;
if (table[i].target) {
const char *target = NULL;
const char *s;
const char *target = NULL, *s;
/* check if one of the targets exists */
NULSTR_FOREACH(s, table[i].target) {