picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libudev: queue - fix get_seqnum_is_finished() 

On Thu, Apr 23, 2009 at 11:39, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> I'm puzzled by this function:
>
>        /* if we have not seen this seqnum, check if it is/was already queued */
>        if (seqnum < udev_queue->last_seen_udev_seqnum) {
>                udev_queue_get_udev_seqnum(udev_queue);
>                if (seqnum < udev_queue->last_seen_udev_seqnum)
>
> Shouldn't the test be (seqnum > udev_queue->last_seen_udev_seqnum) ?
This commit is contained in:
Kay Sievers 2009-04-23 13:23:45 +02:00
parent 08a7a795f6
commit 8c3ae78546
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
udev/lib/libudev-queue.c
View File

@ -179,11 +179,10 @@ int udev_queue_get_seqnum_is_finished(struct udev_queue *udev_queue, unsigned lo
if (udev_queue == NULL)
return -EINVAL;
/* if we have not seen this seqnum, check if it is/was already queued */
if (seqnum < udev_queue->last_seen_udev_seqnum) {
udev_queue_get_udev_seqnum(udev_queue);
if (seqnum < udev_queue->last_seen_udev_seqnum)
if (seqnum > udev_queue->last_seen_udev_seqnum)
if (seqnum > udev_queue_get_udev_seqnum(udev_queue))
return 0;
}
snprintf(filename, sizeof(filename), "%s/.udev/queue/%llu",
udev_get_dev_path(udev_queue->udev), seqnum);
if (lstat(filename, &statbuf) == 0)