Remove a bunch of unused variables

gcc does not warn about those, because of the _cleanup_ usage.
clang is smarter here.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2017-11-01 22:32:22 +01:00
parent 41dfa61d35
commit ac097c841e
8 changed files with 3 additions and 10 deletions

View file

@ -245,7 +245,6 @@ int ask_string(char **ret, const char *text, ...) {
int reset_terminal_fd(int fd, bool switch_to_text) {
struct termios termios;
_cleanup_free_ char *utf8 = NULL;
int r = 0;
/* Set terminal to some sane defaults */

View file

@ -1177,8 +1177,6 @@ int bus_exec_context_set_transient_property(
return sd_bus_error_setf(error, SD_BUS_ERROR_INVALID_ARGS, "Invalid personality");
if (mode != UNIT_CHECK) {
_cleanup_free_ char *str = NULL;
c->personality = p;
unit_write_drop_in_private_format(u, mode, name, "%s=%s", name, s);
}

View file

@ -56,7 +56,7 @@ static bool arg_root_enabled = true;
static bool arg_root_rw = false;
static int add_cryptsetup(const char *id, const char *what, bool rw, bool require, char **device) {
_cleanup_free_ char *e = NULL, *n = NULL, *p = NULL, *d = NULL, *to = NULL;
_cleanup_free_ char *e = NULL, *n = NULL, *p = NULL, *d = NULL;
_cleanup_fclose_ FILE *f = NULL;
char *ret;
int r;

View file

@ -228,7 +228,7 @@ int main(int argc, char *argv[]) {
} mode = MODE_BISECT;
Type type = TYPE_LEGACY;
int i, pair[2] = { -1, -1 };
_cleanup_free_ char *name = NULL, *bus_name = NULL, *address = NULL, *server_name = NULL;
_cleanup_free_ char *address = NULL, *server_name = NULL;
_cleanup_close_ int bus_ref = -1;
const char *unique;
cpu_set_t cpuset;

View file

@ -1136,7 +1136,6 @@ void session_restore_vt(Session *s) {
.mode = VT_AUTO,
};
_cleanup_free_ char *utf8 = NULL;
int vt, old_fd;
/* We need to get a fresh handle to the virtual terminal,

View file

@ -672,7 +672,6 @@ int config_parse_routing_policy_rule_fwmark_mask(
void *userdata) {
_cleanup_routing_policy_rule_free_ RoutingPolicyRule *n = NULL;
_cleanup_free_ char *fwmark = NULL;
Network *network = userdata;
int r;
@ -751,7 +750,7 @@ int config_parse_routing_policy_rule_prefix(
}
static int routing_policy_rule_read_full_file(char *state_file, char **ret) {
_cleanup_free_ char *s = NULL, *p = NULL;
_cleanup_free_ char *s = NULL;
size_t size;
int r;

View file

@ -245,7 +245,6 @@ static int acquire_generator_dirs(
char **generator_early,
char **generator_late) {
_cleanup_(rmdir_and_freep) char *t = NULL;
_cleanup_free_ char *x = NULL, *y = NULL, *z = NULL;
const char *prefix;

View file

@ -704,7 +704,6 @@ static void test_read_line_one_file(FILE *f) {
static void test_read_line(void) {
_cleanup_fclose_ FILE *f = NULL;
_cleanup_free_ char *line = NULL;
f = fmemopen((void*) buffer, sizeof(buffer), "re");
assert_se(f);