From acd380c45049e4eadf874db36cf747e52f477104 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Mon, 14 May 2018 10:04:21 +0900 Subject: [PATCH] resolve: use BUS_DEFINE_PROPERTY_GET* macros --- src/resolve/resolved-bus.c | 36 ++------------------------------- src/resolve/resolved-link-bus.c | 35 ++------------------------------ 2 files changed, 4 insertions(+), 67 deletions(-) diff --git a/src/resolve/resolved-bus.c b/src/resolve/resolved-bus.c index be978dd3bb..0060a1caba 100644 --- a/src/resolve/resolved-bus.c +++ b/src/resolve/resolved-bus.c @@ -1438,40 +1438,6 @@ static int bus_property_get_dnssec_statistics( (uint64_t) m->n_dnssec_verdict[DNSSEC_INDETERMINATE]); } -static int bus_property_get_dnssec_supported( - sd_bus *bus, - const char *path, - const char *interface, - const char *property, - sd_bus_message *reply, - void *userdata, - sd_bus_error *error) { - - Manager *m = userdata; - - assert(reply); - assert(m); - - return sd_bus_message_append(reply, "b", manager_dnssec_supported(m)); -} - -static int bus_property_get_dnssec_mode( - sd_bus *bus, - const char *path, - const char *interface, - const char *property, - sd_bus_message *reply, - void *userdata, - sd_bus_error *error) { - - Manager *m = userdata; - - assert(reply); - assert(m); - - return sd_bus_message_append(reply, "s", dnssec_mode_to_string(manager_get_dnssec_mode(m))); -} - static int bus_property_get_ntas( sd_bus *bus, const char *path, @@ -1503,6 +1469,8 @@ static int bus_property_get_ntas( } static BUS_DEFINE_PROPERTY_GET_ENUM(bus_property_get_dns_stub_listener_mode, dns_stub_listener_mode, DnsStubListenerMode); +static BUS_DEFINE_PROPERTY_GET(bus_property_get_dnssec_supported, "b", Manager, manager_dnssec_supported); +static BUS_DEFINE_PROPERTY_GET2(bus_property_get_dnssec_mode, "s", Manager, manager_get_dnssec_mode, dnssec_mode_to_string); static int bus_method_reset_statistics(sd_bus_message *message, void *userdata, sd_bus_error *error) { Manager *m = userdata; diff --git a/src/resolve/resolved-link-bus.c b/src/resolve/resolved-link-bus.c index ceaf71a71d..a1fc3ad9d5 100644 --- a/src/resolve/resolved-link-bus.c +++ b/src/resolve/resolved-link-bus.c @@ -15,22 +15,8 @@ #include "resolved-resolv-conf.h" #include "strv.h" -static int property_get_dnssec_mode( - sd_bus *bus, - const char *path, - const char *interface, - const char *property, - sd_bus_message *reply, - void *userdata, - sd_bus_error *error) { - - Link *l = userdata; - - assert(reply); - assert(l); - - return sd_bus_message_append(reply, "s", dnssec_mode_to_string(link_get_dnssec_mode(l))); -} +static BUS_DEFINE_PROPERTY_GET(property_get_dnssec_supported, "b", Link, link_dnssec_supported); +static BUS_DEFINE_PROPERTY_GET2(property_get_dnssec_mode, "s", Link, link_get_dnssec_mode, dnssec_mode_to_string); static int property_get_dns( sd_bus *bus, @@ -163,23 +149,6 @@ static int property_get_ntas( return sd_bus_message_close_container(reply); } -static int property_get_dnssec_supported( - sd_bus *bus, - const char *path, - const char *interface, - const char *property, - sd_bus_message *reply, - void *userdata, - sd_bus_error *error) { - - Link *l = userdata; - - assert(reply); - assert(l); - - return sd_bus_message_append(reply, "b", link_dnssec_supported(l)); -} - static int verify_unmanaged_link(Link *l, sd_bus_error *error) { assert(l);