picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

journal/compress: use LZ4_compress_continue()

Browse source 
We can't use LZ4_compress_limitedOutput_continue() because in the
worst-case scenario the compressed output can be slightly bigger than
the input block. This generally affects very few blocks and is no reason
to abort the compression process.

I ran into this when I noticed that Chromium core dumps weren't being
compressed. After switching to LZ4_compress_continue() a ~330MB Chromium
core dump gets compressed to ~17M.
This commit is contained in:
Evangelos Foutras 2014-08-30 10:13:43 +03:00 committed by Zbigniew Jędrzejewski-Szmek
parent f697185e5b
commit b4232628f3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/journal/compress.c
View file

@ -460,10 +460,10 @@ int compress_stream_lz4(int fdf, int fdt, off_t max_bytes) {
total_in += n;
r = LZ4_compress_limitedOutput_continue(&lz4_data, buf, out, n, n);
r = LZ4_compress_continue(&lz4_data, buf, out, n);
if (r == 0) {
log_debug("Compressed size exceeds original, aborting compression.");
return -ENOBUFS;
log_error("LZ4 compression failed.");
return -EBADMSG;
}
header = htole32(r);