picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

dhcp: fix sd_dhcp_client_set_client_id() for infiniband addresses

Browse source 
Infiniband addresses are 20 bytes (INFINIBAND_ALEN), but only the last
8 bytes are suitable for putting into the client-id.

This bug had no effect for networkd, because sd_dhcp_client_set_client_id()
has only one caller which always uses ARPHRD_ETHER type.

I was unable to find good references for why this is correct ([1]). Fedora/RHEL
has patches for ISC dhclient that also only use the last 8 bytes ([2], [3]).
RFC 4390 (Dynamic Host Configuration Protocol (DHCP) over InfiniBand) [4] does
not discuss the content of the client-id either.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1658057#c29
[2] https://bugzilla.redhat.com/show_bug.cgi?id=660681
[3] 3ccf3c8d81/f/dhcp-lpf-ib.patch
[4] https://tools.ietf.org/html/rfc4390
This commit is contained in:
Thomas Haller 2018-12-20 13:05:13 +01:00
parent fcfb1f775e
commit b9d8071458
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/libsystemd-network/sd-dhcp-client.c
View file

@ -308,7 +308,9 @@ int sd_dhcp_client_set_client_id(
break;
case ARPHRD_INFINIBAND:
if (data_len != INFINIBAND_ALEN)
/* Infiniband addresses are 20 bytes (INFINIBAND_ALEN), however only
* the last 8 bytes are stable and suitable for putting into the client-id. */
if (data_len != 8)
return -EINVAL;
break;