From be7468f07ad2b0265033545bff9462ab0391e96d Mon Sep 17 00:00:00 2001 From: Susant Sahani Date: Fri, 10 May 2019 17:47:45 +0530 Subject: [PATCH] LLDP: Fix logs for LLDP ``` May 10 11:08:54 test systemd-networkd[447]: wwan0: Failed to stop LLDP: Success May 10 11:08:54 test systemd-networkd[447]: wwan0: Gained carrier May 10 11:08:54 test systemd-networkd[447]: wwan0: Failed to start LLDP: Success ``` --- src/network/networkd-link.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c index 9c6dc4d6d6..af83cb4935 100644 --- a/src/network/networkd-link.c +++ b/src/network/networkd-link.c @@ -3027,16 +3027,16 @@ static int link_update_lldp(Link *link) { if (link->flags & IFF_UP) { r = sd_lldp_start(link->lldp); + if (r < 0) + return log_link_warning_errno(link, r, "Failed to start LLDP: %m"); if (r > 0) log_link_debug(link, "Started LLDP."); - else - log_link_warning_errno(link, r, "Failed to start LLDP: %m"); } else { r = sd_lldp_stop(link->lldp); + if (r < 0) + return log_link_warning_errno(link, r, "Failed to stop LLDP: %m"); if (r > 0) log_link_debug(link, "Stopped LLDP."); - else - log_link_warning_errno(link, r, "Failed to stop LLDP: %m"); } return r;