From bf795c47bc0eff0a8a4eed21d82d69a3573b3611 Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Sat, 4 Jul 2020 20:18:02 +0200 Subject: [PATCH] test: use KILL instead of SIGKILL in TEST-52-HONORFIRSTSHUTDOWN SIG-prefixed signals for `kill` are not POSIX compliant, so on Ubuntu CI (which defaults to dash instead of bash) the TEST-52 contains following error: [ 9693.549638] sh[51]: + systemctl poweroff --no-block [ 9693.553130] systemd-logind[26]: System is powering down. [ 9693.608911] sh[54]: /bin/sh: 1: kill: Illegal option -S This can be reproduced manually as well, either by running dash, or bash in POSIX mode: $ dash -c 'kill -SIGKILL 123' dash: 1: kill: Illegal option -S $ bash --posix -c 'kill -SIGKILL 123' bash: line 0: kill: SIGKILL: invalid signal specification --- test/units/test-honor-first-shutdown.service | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/units/test-honor-first-shutdown.service b/test/units/test-honor-first-shutdown.service index 374f1e6b5f..3170f979e2 100644 --- a/test/units/test-honor-first-shutdown.service +++ b/test/units/test-honor-first-shutdown.service @@ -4,8 +4,8 @@ After=multi-user.target [Service] ExecStart=/usr/lib/systemd/tests/testdata/units/%N.sh -ExecStop=sh -c 'kill -SIGKILL $MAINPID' +ExecStop=sh -c 'kill -KILL $MAINPID' FailureAction=reboot [Install] -WantedBy=multi-user.target \ No newline at end of file +WantedBy=multi-user.target