From c238a2f8899b4c37d21ed2775e4be5c050a9a1eb Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 14 Jan 2020 16:32:20 +0100 Subject: [PATCH] cgroup: minor comment improvement As pointed out here: https://github.com/systemd/systemd/pull/14564#discussion_r366305882 --- src/core/cgroup.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/core/cgroup.c b/src/core/cgroup.c index fdb134b99f..89fa97cb60 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -2337,13 +2337,13 @@ static void unit_add_siblings_to_cgroup_realize_queue(Unit *u) { /* This adds the siblings of the specified unit and the siblings of all parent units to the cgroup * queue. (But neither the specified unit itself nor the parents.) * - * Propagation of realization "side-ways" (i.e. towards siblings) is in relevant on cgroup-v1 where - * scheduling become very weird if two units that own processes reside in the same slice, but one is - * realized in the "cpu" hierarchy and once is not (for example because one has CPUWeight= set and - * the other does not), because that means processes need to be scheduled against groups. Let's avoid - * this asymmetry by always ensuring that units below a slice that are realized at all are hence - * always realized in *all* their hierarchies, and it is sufficient for a unit's sibling to be - * realized for a unit to be realized too. */ + * Propagation of realization "side-ways" (i.e. towards siblings) is relevant on cgroup-v1 where + * scheduling becomes very weird if two units that own processes reside in the same slice, but one is + * realized in the "cpu" hierarchy and one is not (for example because one has CPUWeight= set and the + * other does not), because that means individual processes need to be scheduled against whole + * cgroups. Let's avoid this asymmetry by always ensuring that units below a slice that are realized + * at all are always realized in *all* their hierarchies, and it is sufficient for a unit's sibling + * to be realized for the unit itself to be realized too. */ while ((slice = UNIT_DEREF(u->slice))) { Iterator i;