picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

systemd-coredump: Ignore coredumps larger than COREDUMP_MAX

Browse source 
Currently this check happens when the coredump has been collected in
it's entirety and being received by journald. this is not ideal
behaviour when the crashing process is consuming significant percentage
of physical memory such as a large instance of firefox or a java
application.
This commit is contained in:
Andrew Cook 2013-09-04 23:27:40 +10:00 committed by Harald Hoyer
parent 489798614c
commit ca0ceb6f3e
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/journal/coredump.c
View file

@ -41,7 +41,7 @@
#define COREDUMP_MIN_START (3*1024*1024)
/* Make sure to not make this larger than the maximum journal entry
* size. See ENTRY_SIZE_MAX in journald-native.c. */
#define COREDUMP_MAX (768*1024*1024)
#define COREDUMP_MAX (767*1024*1024)
enum {
ARG_PID = 1,
@ -258,6 +258,12 @@ int main(int argc, char* argv[]) {
break;
coredump_size += n;
if(coredump_size > COREDUMP_MAX) {
log_error("Coredump too large, ignoring");
goto finish;
}
if (!GREEDY_REALLOC(coredump_data, coredump_bufsize, coredump_size + 1)) {
r = log_oom();
goto finish;