From ce691f31aafe4492011aa94600453ce69662b910 Mon Sep 17 00:00:00 2001 From: Evgeny Vereshchagin Date: Wed, 31 Jan 2018 11:54:37 +0300 Subject: [PATCH] test-lldp: use `memcmp` to compare bytes (#8054) Technically, `data` is a sequence of bytes without a trailing zero, so the use of `memcmp` seems to be logical here. Besides, this helps get around a bug that makes `asan` report the false positive mentioned in #8052. Closes #8052. --- src/libsystemd-network/test-lldp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-network/test-lldp.c b/src/libsystemd-network/test-lldp.c index b91797cb66..5f6829cf6d 100644 --- a/src/libsystemd-network/test-lldp.c +++ b/src/libsystemd-network/test-lldp.c @@ -139,7 +139,7 @@ static void test_receive_basic_packet(sd_event *e) { assert_se(sd_lldp_neighbor_get_port_id(neighbors[0], &type, &data, &length) == 0); assert_se(type == SD_LLDP_PORT_SUBTYPE_INTERFACE_NAME); assert_se(length == 3); - assert_se(strneq((char *) data, "1/3", 3)); + assert_se(!memcmp(data, "1/3", 3)); assert_se(sd_lldp_neighbor_get_port_description(neighbors[0], &str) == 0); assert_se(streq(str, "Port"));