Merge pull request #1023 from poettering/resolved-fixes
A variety of resolved fixes
This commit is contained in:
Tom Gundersen
commit
dd42560795
|
|
@ -490,7 +490,7 @@ static int parse_argv(int argc, char *argv[]) {
|
|||
{ "version", no_argument, NULL, ARG_VERSION },
|
||||
{ "type", required_argument, NULL, 't' },
|
||||
{ "class", required_argument, NULL, 'c' },
|
||||
{ "legend", optional_argument, NULL, ARG_LEGEND },
|
||||
{ "legend", optional_argument, NULL, ARG_LEGEND },
|
||||
{ "protocol", required_argument, NULL, 'p' },
|
||||
{}
|
||||
};
|
||||
|
|
@ -520,11 +520,21 @@ static int parse_argv(int argc, char *argv[]) {
|
|||
arg_family = AF_INET6;
|
||||
break;
|
||||
|
||||
case 'i':
|
||||
arg_ifindex = if_nametoindex(optarg);
|
||||
if (arg_ifindex <= 0)
|
||||
return log_error_errno(errno, "Unknown interfaces %s: %m", optarg);
|
||||
case 'i': {
|
||||
int ifi;
|
||||
|
||||
if (safe_atoi(optarg, &ifi) >= 0 && ifi > 0)
|
||||
arg_ifindex = ifi;
|
||||
else {
|
||||
ifi = if_nametoindex(optarg);
|
||||
if (ifi <= 0)
|
||||
return log_error_errno(errno, "Unknown interface %s: %m", optarg);
|
||||
|
||||
arg_ifindex = ifi;
|
||||
}
|
||||
|
||||
break;
|
||||
}
|
||||
|
||||
case 't':
|
||||
if (streq(optarg, "help")) {
|
||||
|
|
|
|||
|
|
@ -226,10 +226,6 @@ static void bus_method_resolve_hostname_complete(DnsQuery *q) {
|
|||
* query, this time with the cname */
|
||||
if (added <= 0) {
|
||||
r = dns_query_go(q);
|
||||
if (r == -ESRCH) {
|
||||
r = sd_bus_reply_method_errorf(q->request, BUS_ERROR_NO_NAME_SERVERS, "No appropriate name servers or networks for name found");
|
||||
goto finish;
|
||||
}
|
||||
if (r < 0) {
|
||||
r = sd_bus_reply_method_errno(q->request, -r, NULL);
|
||||
goto finish;
|
||||
|
|
@ -346,10 +342,6 @@ static int bus_method_resolve_hostname(sd_bus_message *message, void *userdata,
|
|||
r = dns_query_go(q);
|
||||
if (r < 0) {
|
||||
dns_query_free(q);
|
||||
|
||||
if (r == -ESRCH)
|
||||
sd_bus_error_setf(error, BUS_ERROR_NO_NAME_SERVERS, "No appropriate name servers or networks for name found");
|
||||
|
||||
return r;
|
||||
}
|
||||
|
||||
|
|
@ -494,10 +486,6 @@ static int bus_method_resolve_address(sd_bus_message *message, void *userdata, s
|
|||
r = dns_query_go(q);
|
||||
if (r < 0) {
|
||||
dns_query_free(q);
|
||||
|
||||
if (r == -ESRCH)
|
||||
sd_bus_error_setf(error, BUS_ERROR_NO_NAME_SERVERS, "No appropriate name servers or networks for name found");
|
||||
|
||||
return r;
|
||||
}
|
||||
|
||||
|
|
@ -647,10 +635,6 @@ static int bus_method_resolve_record(sd_bus_message *message, void *userdata, sd
|
|||
r = dns_query_go(q);
|
||||
if (r < 0) {
|
||||
dns_query_free(q);
|
||||
|
||||
if (r == -ESRCH)
|
||||
sd_bus_error_setf(error, BUS_ERROR_NO_NAME_SERVERS, "No appropriate name servers or networks for name found");
|
||||
|
||||
return r;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -651,12 +651,8 @@ int dns_query_go(DnsQuery *q) {
|
|||
DnsTransactionState state = DNS_TRANSACTION_NO_SERVERS;
|
||||
|
||||
dns_query_synthesize_reply(q, &state);
|
||||
if (state != DNS_TRANSACTION_NO_SERVERS) {
|
||||
dns_query_complete(q, state);
|
||||
return 1;
|
||||
}
|
||||
|
||||
return -ESRCH;
|
||||
dns_query_complete(q, state);
|
||||
return 1;
|
||||
}
|
||||
|
||||
r = dns_query_add_transaction_split(q, first);
|
||||
|
|
|
|||
|
|
@ -78,8 +78,7 @@ DnsScope* dns_scope_free(DnsScope *s) {
|
|||
|
||||
dns_scope_llmnr_membership(s, false);
|
||||
|
||||
while ((t = s->transactions)) {
|
||||
|
||||
while ((t = hashmap_steal_first(s->transactions))) {
|
||||
/* Abort the transaction, but make sure it is not
|
||||
* freed while we still look at it */
|
||||
|
||||
|
|
@ -90,6 +89,8 @@ DnsScope* dns_scope_free(DnsScope *s) {
|
|||
dns_transaction_free(t);
|
||||
}
|
||||
|
||||
hashmap_free(s->transactions);
|
||||
|
||||
while ((rr = ordered_hashmap_steal_first(s->conflict_queue)))
|
||||
dns_resource_record_unref(rr);
|
||||
|
||||
|
|
@ -623,24 +624,20 @@ DnsTransaction *dns_scope_find_transaction(DnsScope *scope, DnsResourceKey *key,
|
|||
assert(scope);
|
||||
assert(key);
|
||||
|
||||
/* Try to find an ongoing transaction that is a equal or a
|
||||
* superset of the specified question */
|
||||
/* Try to find an ongoing transaction that is a equal to the
|
||||
* specified question */
|
||||
t = hashmap_get(scope->transactions, key);
|
||||
if (!t)
|
||||
return NULL;
|
||||
|
||||
LIST_FOREACH(transactions_by_scope, t, scope->transactions) {
|
||||
/* Refuse reusing transactions that completed based on cached
|
||||
* data instead of a real packet, if that's requested. */
|
||||
if (!cache_ok &&
|
||||
IN_SET(t->state, DNS_TRANSACTION_SUCCESS, DNS_TRANSACTION_FAILURE) &&
|
||||
!t->received)
|
||||
return NULL;
|
||||
|
||||
/* Refuse reusing transactions that completed based on
|
||||
* cached data instead of a real packet, if that's
|
||||
* requested. */
|
||||
if (!cache_ok &&
|
||||
IN_SET(t->state, DNS_TRANSACTION_SUCCESS, DNS_TRANSACTION_FAILURE) &&
|
||||
!t->received)
|
||||
continue;
|
||||
|
||||
if (dns_resource_key_equal(t->key, key) > 0)
|
||||
return t;
|
||||
}
|
||||
|
||||
return NULL;
|
||||
return t;
|
||||
}
|
||||
|
||||
static int dns_scope_make_conflict_packet(
|
||||
|
|
|
|||
|
|
@ -60,7 +60,7 @@ struct DnsScope {
|
|||
usec_t resend_timeout;
|
||||
usec_t max_rtt;
|
||||
|
||||
LIST_HEAD(DnsTransaction, transactions);
|
||||
Hashmap *transactions;
|
||||
|
||||
LIST_FIELDS(DnsScope, scopes);
|
||||
};
|
||||
|
|
|
|||
|
|
@ -35,7 +35,6 @@ DnsTransaction* dns_transaction_free(DnsTransaction *t) {
|
|||
|
||||
sd_event_source_unref(t->timeout_event_source);
|
||||
|
||||
dns_resource_key_unref(t->key);
|
||||
dns_packet_unref(t->sent);
|
||||
dns_packet_unref(t->received);
|
||||
dns_answer_unref(t->cached);
|
||||
|
|
@ -47,12 +46,14 @@ DnsTransaction* dns_transaction_free(DnsTransaction *t) {
|
|||
dns_stream_free(t->stream);
|
||||
|
||||
if (t->scope) {
|
||||
LIST_REMOVE(transactions_by_scope, t->scope->transactions, t);
|
||||
hashmap_remove(t->scope->transactions, t->key);
|
||||
|
||||
if (t->id != 0)
|
||||
hashmap_remove(t->scope->manager->dns_transactions, UINT_TO_PTR(t->id));
|
||||
}
|
||||
|
||||
dns_resource_key_unref(t->key);
|
||||
|
||||
while ((q = set_steal_first(t->queries)))
|
||||
set_remove(q->transactions, t);
|
||||
set_free(t->queries);
|
||||
|
|
@ -89,14 +90,18 @@ int dns_transaction_new(DnsTransaction **ret, DnsScope *s, DnsResourceKey *key)
|
|||
if (r < 0)
|
||||
return r;
|
||||
|
||||
r = hashmap_ensure_allocated(&s->transactions, &dns_resource_key_hash_ops);
|
||||
if (r < 0)
|
||||
return r;
|
||||
|
||||
t = new0(DnsTransaction, 1);
|
||||
if (!t)
|
||||
return -ENOMEM;
|
||||
|
||||
t->dns_fd = -1;
|
||||
|
||||
t->key = dns_resource_key_ref(key);
|
||||
|
||||
/* Find a fresh, unused transaction id */
|
||||
do
|
||||
random_bytes(&t->id, sizeof(t->id));
|
||||
while (t->id == 0 ||
|
||||
|
|
@ -108,7 +113,12 @@ int dns_transaction_new(DnsTransaction **ret, DnsScope *s, DnsResourceKey *key)
|
|||
return r;
|
||||
}
|
||||
|
||||
LIST_PREPEND(transactions_by_scope, s->transactions, t);
|
||||
r = hashmap_put(s->transactions, t->key, t);
|
||||
if (r < 0) {
|
||||
hashmap_remove(s->manager->dns_transactions, UINT_TO_PTR(t->id));
|
||||
return r;
|
||||
}
|
||||
|
||||
t->scope = s;
|
||||
|
||||
if (ret)
|
||||
|
|
@ -274,7 +284,7 @@ static int dns_transaction_open_tcp(DnsTransaction *t) {
|
|||
if (r == 0)
|
||||
return -EINVAL;
|
||||
if (family != t->scope->family)
|
||||
return -EAFNOSUPPORT;
|
||||
return -ESRCH;
|
||||
|
||||
fd = dns_scope_tcp_socket(t->scope, family, &address, LLMNR_PORT, NULL);
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue