picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

CODING_STYLE: clarify that we really should use O_CLOEXEC everywhere

Browse source
This commit is contained in:
Lennart Poettering 2014-10-30 17:05:25 +01:00
parent 45071fcaa0
commit dd4540da0e
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
CODING_STYLE
View file

@ -190,3 +190,8 @@
- Do not write functions that clobber call-by-reference variables on - Do not write functions that clobber call-by-reference variables on
failure. Use temporary variables for these cases and change the failure. Use temporary variables for these cases and change the
passed in variables only on success. passed in variables only on success.
- When you allocate a file descriptor, it should be made O_CLOEXEC
right from the beginning, as none of our files should leak to forked
binaries by default. Hence, whenever you open a file, O_CLOEXEC must
be specified, right from the beginning.