build-sys: use -Og instead of -O0 to catch warnings

$ touch src/core/dbus.c; make CFLAGS=-O0
  make --no-print-directory all-recursive
  Making all in .
    CC       src/core/libsystemd_core_la-dbus.lo
    CCLD     libsystemd-core.la

  $ touch src/core/dbus.c; make CFLAGS=-Og
  make --no-print-directory all-recursive
  Making all in .
    CC       src/core/libsystemd_core_la-dbus.lo
  src/core/dbus.c: In function 'init_registered_system_bus':
  src/core/dbus.c:798:18: warning: 'id' may be used uninitialized in this function [-Wmaybe-uninitialized]
           dbus_free(id);
                    ^
    CCLD     libsystemd-core.la

-Og Optimize debugging experience. -Og enables optimizations that do
not interfere with debugging. It should be the optimization level of
choice for the standard edit-compile-debug cycle, offering a
reasonable level of optimization while maintaining fast compilation
and a good debugging experience.
This commit is contained in:
Kay Sievers 2013-10-21 15:24:18 +02:00
parent d1f0e886e1
commit df28bc0836
5 changed files with 10 additions and 6 deletions

View file

@ -54,7 +54,7 @@ args="$args \
fi
if [ "x$1" = "xc" ]; then
./configure CFLAGS='-g -O0' $args
./configure CFLAGS='-g -Og' $args
make clean
else
echo

View file

@ -153,7 +153,7 @@ static int generate(char id[34]) {
int machine_id_setup(void) {
_cleanup_close_ int fd = -1;
int r;
bool writable;
bool writable = false;
struct stat st;
char id[34]; /* 32 + \n + \0 */

View file

@ -2062,7 +2062,7 @@ void manager_dispatch_bus_query_pid_done(
int manager_open_serialization(Manager *m, FILE **_f) {
char *path = NULL;
int fd;
int fd = -1;
FILE *f;
assert(_f);

View file

@ -250,7 +250,8 @@ static int create_socket(char **name) {
} sa = {
.un.sun_family = AF_UNIX,
};
int one = 1, r;
int one = 1;
int r = 0;
char *c;
assert(name);

View file

@ -465,8 +465,10 @@ static int item_set_perms(Item *i, const char *path) {
}
static int write_one_file(Item *i, const char *path) {
int r, e, fd, flags;
int e, flags;
int fd = -1;
struct stat st;
int r = 0;
flags = i->type == CREATE_FILE ? O_CREAT|O_APPEND :
i->type == TRUNCATE_FILE ? O_CREAT|O_TRUNC : 0;
@ -638,8 +640,9 @@ static int glob_item(Item *i, int (*action)(Item *, const char *)) {
}
static int create_item(Item *i) {
int r, e;
int e;
struct stat st;
int r = 0;
assert(i);