picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

automount: fix segfault when shutting down 

https://bugs.freedesktop.org/show_bug.cgi?id=32076
This commit is contained in:
Lennart Poettering 2011-01-21 01:13:09 +01:00
parent 76e7bc8dfb
commit e0fa621b8b
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
TODO
View File

@ -9,9 +9,6 @@ Bugs:
* somehow some /etc/fstab supplied mount params are never applied to api fs
https://bugzilla.redhat.com/show_bug.cgi?id=663108
* automount units can cause a segfault:
https://bugs.freedesktop.org/show_bug.cgi?id=32076
* bind mounts with 'fsck' fail and block for a minute:
/foo /bar none bind 1 1
(requesting fsck is wrong, but why do we block for a minute

9
src/mount.c
View File

@ -98,12 +98,21 @@ static void mount_parameters_done(MountParameters *p) {
static void mount_done(Unit *u) {
Mount *m = MOUNT(u);
Meta *other;
assert(m);
free(m->where);
m->where = NULL;
/* Try to detach us from the automount unit if there is any */
LIST_FOREACH(units_per_type, other, m->meta.manager->units_per_type[UNIT_AUTOMOUNT]) {
Automount *a = (Automount*) other;
if (a->mount == m)
a->mount = NULL;
}
mount_parameters_done(&m->parameters_etc_fstab);
mount_parameters_done(&m->parameters_proc_self_mountinfo);
mount_parameters_done(&m->parameters_fragment);