picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

mount: use free_and_strdup() over plain strdup()

Browse source 
Let's initialize two fields with free_and_strdup() rather than directly
with strdup(). The fields should not be initialized so far, but it's
still nicer to be prepared for futzre code changes and always free
what's stored before replacing it.
This commit is contained in:
Lennart Poettering 2018-11-28 14:40:56 +01:00
parent 60b8c203f8
commit e10fe04266
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/mount.c
View file

@ -1475,13 +1475,13 @@ static int mount_setup_new_unit(
if (r < 0)
return r;
u->source_path = strdup("/proc/self/mountinfo");
MOUNT(u)->where = strdup(where);
if (!u->source_path || !MOUNT(u)->where)
return -ENOMEM;
r = free_and_strdup(&u->source_path, "/proc/self/mountinfo");
if (r < 0)
return r;
/* Make sure to initialize those fields before mount_is_extrinsic(). */
MOUNT(u)->from_proc_self_mountinfo = true;
r = free_and_strdup(&MOUNT(u)->where, where);
if (r < 0)
return r;
r = update_parameters_proc_self_mount_info(MOUNT(u), what, options, fstype);
if (r < 0)