terminal-util: remove unnecessary check of result of isatty() (#4000)
After the call of the isatty() we check its result twice in the open_terminal(). There are no sense to check result of isatty() that it is less than zero and return -errno, because as described in documentation: isatty() returns 1 if fd is an open file descriptor referring to a terminal; otherwise 0 is returned, and errno is set to indicate the error. So it can't be less than zero.
This commit is contained in:
parent
29272c04a7
commit
e6c9fa74a5
|
@ -346,12 +346,7 @@ int open_terminal(const char *name, int mode) {
|
|||
}
|
||||
|
||||
r = isatty(fd);
|
||||
if (r < 0) {
|
||||
safe_close(fd);
|
||||
return -errno;
|
||||
}
|
||||
|
||||
if (!r) {
|
||||
if (r == 0) {
|
||||
safe_close(fd);
|
||||
return -ENOTTY;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue