picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dbus-execute: avoid extra strdup() 

bind_mount_add does the strdup(), so we can avoid
strdup()ing the strings.
This commit is contained in:
Topi Miettinen 2020-01-02 19:59:48 +02:00 committed by Ronny Chevalier
parent ff963ea6ba
commit ec04aef442
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/dbus-execute.c
View File

@ -2379,7 +2379,7 @@ int bus_exec_context_set_transient_property(
return 1;
} else if (STR_IN_SET(name, "BindPaths", "BindReadOnlyPaths")) {
const char *source, *destination;
char *source, *destination;
int ignore_enoent;
uint64_t mount_flags;
bool empty = true;
@ -2400,8 +2400,8 @@ int bus_exec_context_set_transient_property(
if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
r = bind_mount_add(&c->bind_mounts, &c->n_bind_mounts,
&(BindMount) {
.source = strdup(source),
.destination = strdup(destination),
.source = source,
.destination = destination,
.read_only = !!strstr(name, "ReadOnly"),
.recursive = !!(mount_flags & MS_REC),
.ignore_enoent = ignore_enoent,