From ed024e1d98af8c0b06fdfb0f9f96169f2808baac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
Date: Tue, 10 Dec 2019 14:09:59 +0100
Subject: [PATCH] test: move TEST-05-RLIMITS setup to static files

The test currently fails in the check for LimitNOFILESoft/LimitNOFILE. I see
default values there. This doesn't seem to be related to the changes in the
test suite, but rather to the recent changes to pid1.
---
 test/TEST-05-RLIMITS/test-rlimits.sh | 15 ---------------
 test/TEST-05-RLIMITS/test.sh         | 21 +--------------------
 test/units/testsuite-05.service      |  6 ++++++
 test/units/testsuite-05.sh           | 25 +++++++++++++++++++++++++
 4 files changed, 32 insertions(+), 35 deletions(-)
 delete mode 100755 test/TEST-05-RLIMITS/test-rlimits.sh
 create mode 100644 test/units/testsuite-05.service
 create mode 100755 test/units/testsuite-05.sh

diff --git a/test/TEST-05-RLIMITS/test-rlimits.sh b/test/TEST-05-RLIMITS/test-rlimits.sh
deleted file mode 100755
index 86b57601fe..0000000000
--- a/test/TEST-05-RLIMITS/test-rlimits.sh
+++ /dev/null
@@ -1,15 +0,0 @@
-#!/usr/bin/env bash
-set -x
-set -e
-set -o pipefail
-
-[[ "$(systemctl show -p DefaultLimitNOFILESoft)" = "DefaultLimitNOFILESoft=10000" ]]
-[[ "$(systemctl show -p DefaultLimitNOFILE)" = "DefaultLimitNOFILE=16384" ]]
-
-[[ "$(systemctl show -p LimitNOFILESoft testsuite.service)" = "LimitNOFILESoft=10000" ]]
-[[ "$(systemctl show -p LimitNOFILE testsuite.service)" = "LimitNOFILE=16384" ]]
-
-[[ "$(ulimit -n -S)" = "10000" ]]
-[[ "$(ulimit -n -H)" = "16384" ]]
-
-touch /testok
diff --git a/test/TEST-05-RLIMITS/test.sh b/test/TEST-05-RLIMITS/test.sh
index bda37ef212..6412188ef2 100755
--- a/test/TEST-05-RLIMITS/test.sh
+++ b/test/TEST-05-RLIMITS/test.sh
@@ -14,27 +14,8 @@ test_setup() {
 
         setup_basic_environment
         mask_supporting_services
-
-        cat >$initdir/etc/systemd/system.conf <<EOF
-[Manager]
-DefaultLimitNOFILE=10000:16384
-EOF
-
-        # setup the testsuite service
-        cat >$initdir/etc/systemd/system/testsuite.service <<EOF
-[Unit]
-Description=Testsuite service
-
-[Service]
-ExecStart=/test-rlimits.sh
-Type=oneshot
-EOF
-
-        cp test-rlimits.sh $initdir/
-
-        setup_testsuite
     )
     setup_nspawn_root
 }
 
-do_test "$@"
+do_test "$@" 05
diff --git a/test/units/testsuite-05.service b/test/units/testsuite-05.service
new file mode 100644
index 0000000000..44108d7701
--- /dev/null
+++ b/test/units/testsuite-05.service
@@ -0,0 +1,6 @@
+[Unit]
+Description=TEST-05-RLIMITS
+
+[Service]
+ExecStart=/usr/lib/systemd/tests/testdata/units/%N.sh
+Type=oneshot
diff --git a/test/units/testsuite-05.sh b/test/units/testsuite-05.sh
new file mode 100755
index 0000000000..eed30c8b85
--- /dev/null
+++ b/test/units/testsuite-05.sh
@@ -0,0 +1,25 @@
+#!/usr/bin/env bash
+set -x
+set -e
+set -o pipefail
+
+P=/run/systemd/system.conf.d
+mkdir $P
+
+cat >$P/rlimits.conf <<EOF
+[Manager]
+DefaultLimitNOFILE=10000:16384
+EOF
+
+systemctl daemon-reload
+
+[[ "$(systemctl show --value -p DefaultLimitNOFILESoft)" = "10000" ]]
+[[ "$(systemctl show --value -p DefaultLimitNOFILE)" = "16384" ]]
+
+[[ "$(systemctl show --value -p LimitNOFILESoft testsuite-05.service)" = "10000" ]]
+[[ "$(systemctl show --value -p LimitNOFILE testsuite-05.service)" = "16384" ]]
+
+systemd-run --wait -t bash -c '[[ "$(ulimit -n -S)" = "10000" ]]'
+systemd-run --wait -t bash -c '[[ "$(ulimit -n -H)" = "16384" ]]'
+
+touch /testok